Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analytics: restore safe address in the safe_created event #4077

Merged
merged 2 commits into from
Aug 20, 2024
Merged

Conversation

katspaugh
Copy link
Member

@katspaugh katspaugh commented Aug 20, 2024

What it solves

#3954 restored the safe_created event but not the safe address for it.

How this PR fixes it

I've added a gtmSetSafeAddress call right before the safe_created event is emitted.

How to test it

Create a Safe with "pay now" and check the events in the console.

Screenshot 2024-08-20 at 15 27 34

@katspaugh katspaugh requested a review from schmanu August 20, 2024 13:31
Copy link

github-actions bot commented Aug 20, 2024

Copy link

github-actions bot commented Aug 20, 2024

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

github-actions bot commented Aug 20, 2024

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 944.38 KB (🟡 +7 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Copy link

github-actions bot commented Aug 20, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 78.5% 11729/14941
🔴 Branches 58.92% 2981/5059
🟡 Functions 66% 1877/2844
🟡 Lines 79.89% 10575/13237

Test suite run success

1456 tests passing in 201 suites.

Report generated by 🧪jest coverage report action from fdcc782

@francovenica
Copy link
Contributor

LGTM

I tried safe creation with wallet, with relayer and CF safe creation. The safe-create event is there with the safe address.

Leaving a snapshot for documentation.
image

@katspaugh katspaugh merged commit ad9172b into dev Aug 20, 2024
15 of 16 checks passed
@katspaugh katspaugh deleted the fix-ga branch August 20, 2024 14:45
@github-actions github-actions bot locked and limited conversation to collaborators Aug 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants