Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add CREATED_SAFE event back for normal safe creation #3954

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

usame-algan
Copy link
Member

What it solves

This fixes a regression that was introduced in #3778

How this PR fixes it

#3778 consolidated the logic of counterfactual and normal safe deployment and as such removed existing hooks like useSafeCreationEffects. This hook contained the logic to emit a CREATED_SAFE event on successful creation.

This PR adds this back for normal safe deployments. For counterfactual safe deployments this event is emitted immediately which is as expected.

How to test it

  1. Create a safe and choose pay now
  2. Observe a CREATED_SAFE event after successful deployment

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

Copy link

github-actions bot commented Jul 16, 2024

Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 1012.93 KB (🟡 +27 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Copy link

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 79.01% 11614/14699
🔴 Branches 58.61% 2853/4868
🟡 Functions 65.94% 1855/2813
🟢 Lines 80.4% 10472/13025

Test suite run success

1436 tests passing in 198 suites.

Report generated by 🧪jest coverage report action from aab43eb

@francovenica
Copy link
Contributor

LGTM.

I've checked Safe created when you deploy right away and when you activate a CF safe for comparison:
Created right away:
image

Safe activation:
image

@usame-algan usame-algan merged commit 39323fa into dev Jul 16, 2024
14 checks passed
@usame-algan usame-algan deleted the created-safe-event branch July 16, 2024 20:18
@github-actions github-actions bot locked and limited conversation to collaborators Jul 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants