fix: Add CREATED_SAFE event back for normal safe creation #3954
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
This fixes a regression that was introduced in #3778
How this PR fixes it
#3778 consolidated the logic of counterfactual and normal safe deployment and as such removed existing hooks like
useSafeCreationEffects
. This hook contained the logic to emit aCREATED_SAFE
event on successful creation.This PR adds this back for normal safe deployments. For counterfactual safe deployments this event is emitted immediately which is as expected.
How to test it
CREATED_SAFE
event after successful deploymentChecklist