-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Hide transaction checks block if features are disabled #4008
Conversation
Branch preview✅ Deploy successful! Storybook: |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
📦 Next.js Bundle Analysis for safe-wallet-webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 🎉 Global Bundle Size Decreased
DetailsThe global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster. Any third party scripts you have added directly to your app using the If you want further insight into what is behind the changes, give @next/bundle-analyzer a try! |
Coverage report
Show files with reduced coverage 🔻
Test suite run success1446 tests passing in 200 suites. Report generated by 🧪jest coverage report action from 5440e19 |
@@ -140,9 +140,7 @@ export function RecoverAccountFlowReview({ params }: { params: RecoverAccountFlo | |||
<RedefineBalanceChanges /> | |||
</TxCard> | |||
|
|||
<TxCard> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would keep TxCard here and make it disappear if empty via CSS (:empty { display: none; }
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No gap, looks ok to me
Verified Also enabling/disabling feature works for me on staging without caching issue |
What it solves
Resolves #3584
How this PR fixes it
How to test it
Screenshots
Checklist