Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: restore copiable hex data in the safe app review modal #1970

Merged
merged 1 commit into from
May 10, 2023

Conversation

katspaugh
Copy link
Member

What it solves

Fixes a regression introduced in #1899. The hex data was missing in the Safe App tx modal.

How this PR fixes it

Restores the hex data component.

How to test it

Make a Transaction Builder tx.

Screenshots

Screenshot 2023-05-10 at 09 14 24

@katspaugh katspaugh requested a review from schmanu May 10, 2023 07:14
@github-actions
Copy link

github-actions bot commented May 10, 2023

Branch preview

✅ Deploy successful!

https://restore_hex_data--webcore.review-web-core.5afe.dev

@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link
Member

@schmanu schmanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@katspaugh katspaugh merged commit df1643b into release/1.9.1 May 10, 2023
@katspaugh katspaugh deleted the restore-hex-data branch May 10, 2023 07:31
@github-actions github-actions bot locked and limited conversation to collaborators May 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants