Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: SignOrExecute elements #1842

Merged
merged 11 commits into from
Apr 24, 2023
Merged

refactor: SignOrExecute elements #1842

merged 11 commits into from
Apr 24, 2023

Commits on Apr 4, 2023

  1. Refactor: extract SignOrExecute logic into hooks (#1830) 

    * Refactor: extract SignOrExecute logic into hooks

* isExecutionLoop

* Fix isExecutionLoop

* Add hook tests

* PR comments

* Create asserts

* Use isValidMasterCopy

* Track relayed executions

* Tests
    @katspaugh
    katspaugh authored Apr 4, 2023
    Configuration menu
    Copy the full SHA
    1595cc7 View commit details
    Browse the repository at this point in the history

  2. Refactor: move getRemainingRelays to a service (#1839) 

    * Refactor: move getRemainingRelays to a service

* Rename relaying service and constants
    @katspaugh
    katspaugh authored Apr 4, 2023
    Configuration menu
    Copy the full SHA
    810a22a View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2023

  1. Rm component library draft

    @katspaugh
    katspaugh committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    bed3482 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'dev' into tx-refactor

    @iamacook
    iamacook committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    b361689 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2023

  1. refactor: address relaying review comments (#1848) 

    * refactor: address relaying review comments

* fix: revert type error expectation

* fix: add help article link

* fix: spelling mistake
    @iamacook
    iamacook authored Apr 6, 2023
    Configuration menu
    Copy the full SHA
    e5db84e View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2023

  1. Solve git conflicts

    @katspaugh
    katspaugh committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    d4255af View commit details
    Browse the repository at this point in the history

  2. Merge branch 'dev' of github.com:safe-global/web-core into tx-refactor

    @katspaugh
    katspaugh committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    1d6db52 View commit details
    Browse the repository at this point in the history

  3. Relaying: propose signed tx

    @katspaugh
    katspaugh committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    8291dd9 View commit details
    Browse the repository at this point in the history

  4. Fix tests and add more cases

    @katspaugh
    katspaugh committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    7ce8cd5 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2023

  1. Fix git conflicts

    @katspaugh
    katspaugh committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    0a2a1d2 View commit details
    Browse the repository at this point in the history

  2. Fix test

    @katspaugh
    katspaugh committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    64b2474 View commit details
    Browse the repository at this point in the history