Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signing a message from a DApp crashes the app #1799

Closed
iamacook opened this issue Mar 23, 2023 · 2 comments · Fixed by #1837
Closed

Signing a message from a DApp crashes the app #1799

iamacook opened this issue Mar 23, 2023 · 2 comments · Fixed by #1837
Assignees
Labels
bug Something isn't working major Major bug (to be solved in the next release)

Comments

@iamacook
Copy link
Member

iamacook commented Mar 23, 2023

Bug description

When triggering a message signing from within a DApp (e.g. Snapshot), the app crashes, throwing the following error:

image

Environment

  • DApp: Monerium, Snapshot (probably any dapp that requests a signature)
  • Chain: Ethereum/Gnosis Chain

Steps to reproduce

  1. Open Snapshot.org
  2. Connect a Safe via WalletConnect
  3. Edit Profile on Snapshot
  4. Safe crashes

Expected result

The signing modal opens and you are able to sign a message.

Obtained result

The app crashes.

@iamacook iamacook added bug Something isn't working major Major bug (to be solved in the next release) labels Mar 23, 2023
@katspaugh
Copy link
Member

I can't reproduce it on snapshot.org anymore. Maybe there were issues on the WC bridge?
In any case, the app shouldn't crash. We should catch and handle that error properly.

@iamacook
Copy link
Member Author

I can't reproduce it on snapshot.org anymore. Maybe there were issues on the WC bridge? In any case, the app shouldn't crash. We should catch and handle that error properly.

Neither can I.

I'd suggest we tackle this immediately after #1746 is merged as that touches everything EthersAdapter related.

@iamacook iamacook self-assigned this Apr 3, 2023
@iamacook iamacook mentioned this issue Apr 3, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working major Major bug (to be solved in the next release)
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants