Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Create safe e2e test #1500

Merged
merged 11 commits into from
Jan 9, 2023
Merged

fix: Create safe e2e test #1500

merged 11 commits into from
Jan 9, 2023

Conversation

usame-algan
Copy link
Member

@usame-algan usame-algan commented Jan 9, 2023

What it solves

Resolves #1494 (comment)

Adds a new smoke test for the safe creation flow

@github-actions
Copy link

github-actions bot commented Jan 9, 2023

Branch preview

✅ Deploy successful!

https://create_safe_e2e--webcore.review-web-core.5afe.dev

@github-actions
Copy link

github-actions bot commented Jan 9, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@usame-algan usame-algan force-pushed the create-safe-e2e branch 2 times, most recently from 13b96bd to 464d4a0 Compare January 9, 2023 14:04
@usame-algan usame-algan changed the title WIP: fix: Create safe e2e test fix: Create safe e2e test Jan 9, 2023
@usame-algan usame-algan marked this pull request as ready for review January 9, 2023 14:27
Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for taking the time!

@usame-algan usame-algan merged commit 7348998 into dev Jan 9, 2023
@usame-algan usame-algan deleted the create-safe-e2e branch January 9, 2023 14:41
@github-actions github-actions bot locked and limited conversation to collaborators Jan 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants