Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: rename ExternalLink prop #1460

Merged
merged 1 commit into from
Dec 27, 2022
Merged

refactor: rename ExternalLink prop #1460

merged 1 commit into from
Dec 27, 2022

Conversation

DiogoSoaress
Copy link
Member

What it solves

suppressIcon -> noIcon

@github-actions
Copy link

github-actions bot commented Dec 27, 2022 •
edited
Loading

Branch preview

✅ Deploy successful!

https://refactor_rename_external_link_prop--webcore.review-web-core.5afe.dev

@DiogoSoaress DiogoSoaress mentioned this pull request Dec 27, 2022
Merged
katspaugh
katspaugh approved these changes Dec 27, 2022
View reviewed changes
Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🙇

@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total
Report generated by eslint-plus-action

@katspaugh
Copy link
Member

Tested, works the same as before ✅

@katspaugh katspaugh merged commit f407877 into dev Dec 27, 2022
@katspaugh katspaugh deleted the refactor-rename-external-link-prop branch December 27, 2022 12:54
@github-actions github-actions bot locked and limited conversation to collaborators Dec 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katspaugh katspaugh katspaugh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DiogoSoaress @katspaugh