Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add what are signed messages link to page #1459

Merged
merged 5 commits into from
Dec 29, 2022

Conversation

DiogoSoaress
Copy link
Member

What it solves

Resolves #1430

How this PR fixes it

Adds a link to the Messages page header if there are off-chain signed messages

How to test it

  1. Go to Transactions > Messages in a Safe with off-chain messages signed and you should see the link
  2. Go to Transactions > Messages in a Safe without off-chain messages signed and you should not see the link above the table but instead in the NoMessage placeholder

Screenshots

Screenshot 2022-12-27 at 12 17 02

Screenshot 2022-12-27 at 12 16 47

@github-actions
Copy link

github-actions bot commented Dec 27, 2022

Branch preview

⏳ Deploying a preview site...

@github-actions
Copy link

github-actions bot commented Dec 27, 2022

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@katspaugh
Copy link
Member

Feel free to merge to the epic branch, just update it from dev first and replace the noIcon prop.

@francovenica
Copy link
Contributor

Looks good.
Note that the link is still an empty anchor. Whenever we make an RC for this feature that should have to a have the real link

@DiogoSoaress DiogoSoaress merged commit 9abbfcd into eip-1271 Dec 29, 2022
@DiogoSoaress DiogoSoaress deleted the fix-add-help-link branch December 29, 2022 10:33
@github-actions github-actions bot locked and limited conversation to collaborators Dec 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants