Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TOML icon #1436

Merged
merged 2 commits into from
Nov 26, 2023
Merged

Add TOML icon #1436

merged 2 commits into from
Nov 26, 2023

Conversation

cpea2506
Copy link
Contributor

@cpea2506 cpea2506 commented Nov 22, 2023

Description

The logo is taken from the official repo of TOML.

There is a little change that made the SVG change to black/white color and better optimized.

Requirements / Checklist

What does this Pull Request (PR) do?

Add new icon for TOML

How should this be manually tested?

Any background context you can provide?

What are the relevant tickets (if any)?

Screenshots (if appropriate or helpful)

Screenshot 2023-11-22 at 23 12 49

@Finii
Copy link
Collaborator

Finii commented Nov 22, 2023

Thanks for the nice PR!

Just curiosity, what is your use-case? Yes, to mark your TOML files, I mean what do you use TOML for?
I had the impression everybody is using json these days, even if the readability is less.

@cpea2506
Copy link
Contributor Author

cpea2506 commented Nov 23, 2023

Thanks for the nice PR!

Just curiosity, what is your use-case? Yes, to mark your TOML files, I mean what do you use TOML for? I had the impression everybody is using json these days, even if the readability is less.

Hi, as a Rust user we work with a lot of TOML files since Rust prefer them for readability and minimal syntax.

@Finii
Copy link
Collaborator

Finii commented Nov 26, 2023

Sneaking this in, thanks again

@Finii Finii merged commit a58d12d into ryanoasis:master Nov 26, 2023
1 check passed
@cpea2506 cpea2506 deleted the add-toml-icon branch November 26, 2023 15:07
@Finii
Copy link
Collaborator

Finii commented Nov 26, 2023

@allcontributors please add @cpea2506 for code

Copy link
Contributor

@Finii

I've put up a pull request to add @cpea2506! 🎉

@jcypret
Copy link

jcypret commented Feb 25, 2024

Excited to see this TOML addition! ❤️

FYI: It looks like the Glyph Sets and Code Points Wiki entry is missing this additional codepoint:

- Code Point Ranges: e5fa-e6b1
+ Code Point Ranges: e5fa-e6b2

I noticed when using that wiki as a reference for my Kitty config based on this other discussion: #1189.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants