Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the new code points #1189

Closed
3 tasks done
musjj opened this issue May 1, 2023 · 9 comments
Closed
3 tasks done

Document the new code points #1189

musjj opened this issue May 1, 2023 · 9 comments

Comments

@musjj
Copy link

musjj commented May 1, 2023

Requirements

  • I have searched the issues for my request and found nothing related and/or helpful
  • I have searched the FAQ for help
  • I have searched the Wiki for help

Is your feature request related to a problem? Please describe.
The list of code points are not documented.

Describe the solution you'd like
Document the code points. I need this info, because the Kitty terminal has a special way of loading nerd fonts.

For it to work, you need to specify the normal non-nerd version of the font, and it will automatically load symbols from the nerd version as needed.

But the JetBrains Mono font is named inconsistently (JetBrainsMono Nerd Font and JetBrains Mono), and I think this breaks the auto-loading.

So I have to manually specify the codepoints this way:
https://sw.kovidgoyal.net/kitty/faq/#kitty-is-not-able-to-use-my-favorite-font

font_family JetBrains Mono
symbol_map U+23FB-U+23FE,U+2665,U+26A1,U+2B58,U+E000-U+E00A,
U+E0A0-U+E0A3,U+E0B0-U+E0D4,U+E200-U+E2A9,U+E300-U+E3E3,
U+E5FA-U+E6AA,U+E700-U+E7C5,U+EA60-U+EBEB,U+F000-U+F2E0,
U+F300-U+F32F,U+F400-U+F4A9,U+F500-U+F8FF,U+F0001-U+F1AF0 JetBrainsMono Nerd Font

But this broke on the last update. I assume that the mapping have changed somewhat, so it would be nice to have it documented somewhere.

@Finii
Copy link
Collaborator

Finii commented May 1, 2023

Maybe https://github.com/ryanoasis/nerd-fonts/blob/master/glyphnames.json can help you?

At least on superficial glance your specification looks good, just

  • drop U+F500-U+F8FF
  • exchange U+F400-U+F4A9 to U+F400-U+F532

The documentation would be https://github.com/ryanoasis/nerd-fonts/wiki/Glyph-Sets-and-Code-Points but I did not manage to update many docs yet...

But the JetBrains Mono font is named inconsistently

That depends on what you mean by consistency. That naming scheme is in effect for Nerd Fonts for ... long.
(i.e. dropping the blanks in the original name)

@musjj
Copy link
Author

musjj commented May 1, 2023

I've tried your change, glyphs are no longer blanked out, but it's now displaying the wrong glyphs. It works fine on Wezterm, so I'm pretty sure the program I'm using is outputting the correct code points.

Not sure what's wrong here. For now, I'm just gonna stick to the previous version.

@Finii
Copy link
Collaborator

Finii commented May 5, 2023

Updated https://github.com/ryanoasis/nerd-fonts/wiki/Glyph-Sets-and-Code-Points, so the original issue is fixed.

@Finii Finii closed this as completed May 5, 2023
@musjj
Copy link
Author

musjj commented May 5, 2023

I've updated my code points in my kitty config, but it's still displaying the wrong glyphs. I don't think this is caused by the recent backwards compatibility-breaking update, because Wezterm works just fine.

# Seti-UI + Custom
symbol_map U+E5FA-U+E6AC Symbols Nerd Font Mono
# Devicons
symbol_map U+E700-U+E7C5 Symbols Nerd Font Mono
# Font Awesome
symbol_map U+F000-U+F2E0 Symbols Nerd Font Mono
# Font Awesome Extension
symbol_map U+E200-U+E2A9 Symbols Nerd Font Mono
# Material Design Icons
symbol_map U+F0001-U+F1AF0 Symbols Nerd Font Mono
# Weather
symbol_map U+E300-U+E3E3 Symbols Nerd Font Mono
# Octicons
symbol_map U+F400-U+F532,U+2665,U+26A1 Symbols Nerd Font Mono
# Powerline Symbols
symbol_map U+E0A0-U+E0A2,U+E0B0-U+E0B3 Symbols Nerd Font Mono
# Powerline Extra Symbols
symbol_map U+E0A3,U+E0B4-U+E0C8,U+E0CA,U+E0CC-U+E0D4 Symbols Nerd Font Mono
# IEC Power Symbols
symbol_map U+23FB-U+23FE,U+2B58 Symbols Nerd Font Mono
# Font Logos
symbol_map U+F300-U+F32F Symbols Nerd Font Mono
# Pomicons
symbol_map U+E000-U+E00A Symbols Nerd Font Mono
# Codicons
symbol_map U+EA60-U+EBEB Symbols Nerd Font Mono
# Heavy Angle Brackets
symbol_map U+E276C-U+2771 Symbols Nerd Font Mono
# Box Drawing
symbol_map U+2500-U+259F Symbols Nerd Font Mono

EDIT: Never mind, they were caused by the moved codepoints

@bew
Copy link

bew commented May 6, 2023

@musjj Wezterm was probably working fine because it's using the internal nerdfont symbols, not the one you installed. (wezterm didn't update its nerdfont version afaik)

@Finii
Copy link
Collaborator

Finii commented May 7, 2023

I've updated my code points in my kitty config, but it's still displaying the wrong glyphs.

I do not understand clearly what your issue is. Maybe really raise a new issue. This issue here (documentation missing) is solved, right?

@musjj
Copy link
Author

musjj commented May 7, 2023

Yes, I've put an edit at the bottom of my post clarifying that the issue has been solved, but I guess it's hard to notice.

The issue was caused by incorrect codepoints (due to the recent update), but I misdiagnosed the issue because I forgot about Wezterm's built-in nerd fonts

@Finii
Copy link
Collaborator

Finii commented May 7, 2023

Thank you for clearing this up! 👍

Copy link
Contributor

github-actions bot commented Nov 6, 2023

This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants