Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add old Octicons folder-icon #1227

Merged
merged 4 commits into from
May 11, 2023
Merged

Add old Octicons folder-icon #1227

merged 4 commits into from
May 11, 2023

Commits on May 10, 2023

  1. generate-original-source: Increase icon size

    [why]
    The Seti and Custom icons are smaller than in ancient Nerd Font versions
    and can seem a bit flimsy. In fact we add about 25% of padding (12% left
    and 12% right) to each icon, which seems a bit generous.
    
    This does not show in Nerd Font Mono fonts, because the icons will be
    rescaled there, but in the other fonts.
    
    Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
    Finii committed May 10, 2023
    Configuration menu
    Copy the full SHA
    3d6b75c View commit details
    Browse the repository at this point in the history
  2. Add old octicons folder icon to custom set

    [why]
    Specifically for https://github.com/NvChad/NvChad
    
    Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
    Finii committed May 10, 2023
    Configuration menu
    Copy the full SHA
    b624e7e View commit details
    Browse the repository at this point in the history

Commits on May 11, 2023

  1. original-source: Cleanup four svgs

    [why]
    The CI process produces a different font than running the
    generate-original-source script locally.
    
    Several thing have been checked, to no avail, see #1227.
    
    Turned out the affected SVGs all are somehow ... questionable in their
    construction.
    
    [how]
    Open SVGs in inkscape, select all (points) and generate new, clean
    outline with Path->Union.
    Save as optimized SVG.
    
    The (CI) created font file now looks good.
    
    But the cause is still unknown, maybe some sub-library that is used has
    changed? I have no clue. Meaning it runs ok locally seems to be no
    guarantee it will look the same when run by the CI :-(
    
    Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
    Finii committed May 11, 2023
    Configuration menu
    Copy the full SHA
    2eebf5e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7474a97 View commit details
    Browse the repository at this point in the history