Add old Octicons folder-icon #1227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[why] The Seti and Custom icons are smaller than in ancient Nerd Font versions and can seem a bit flimsy. In fact we add about 25% of padding (12% left and 12% right) to each icon, which seems a bit generous. This does not show in Nerd Font Mono fonts, because the icons will be rescaled there, but in the other fonts. Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
[why] Specifically for https://github.com/NvChad/NvChad Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
|
When the CI build the original-source we get some defects, it is unclear why.
|
|
I think I give up on the CI; tried a lot of things to get the correct output but the CI-created original-source font is always 'broken' while it is ok running the same script with the same tools locally. This takes too much time now, maybe fix 'another day'. |
|
Documenting what the CI runs always get wrong ...:
The left two have minuscule differences, but the right two are really noticeable. When the CI should be re-activated this needs to be checked carefully! Tried
All to no avail. The locally run looks different (correct) while the CI run always has the strange moved points. WorkaroundSee commit 2eebf5e original-source: Cleanup four svgs |
[why] The CI process produces a different font than running the generate-original-source script locally. Several thing have been checked, to no avail, see #1227. Turned out the affected SVGs all are somehow ... questionable in their construction. [how] Open SVGs in inkscape, select all (points) and generate new, clean outline with Path->Union. Save as optimized SVG. The (CI) created font file now looks good. But the cause is still unknown, maybe some sub-library that is used has changed? I have no clue. Meaning it runs ok locally seems to be no guarantee it will look the same when run by the CI :-( Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Finii
force-pushed
the
feature/add-old-oct-folder
branch
from
12ef9a7
to
2eebf5e
Compare
Finii
added a commit
that referenced
this pull request
May 11, 2023
[why] The CI process produces a different font than running the generate-original-source script locally. Several thing have been checked, to no avail, see #1227. Turned out the affected SVGs all are somehow ... questionable in their construction. [how] Open SVGs in inkscape, select all (points) and generate new, clean outline with Path->Union. Save as optimized SVG. The (CI) created font file now looks good. But the cause is still unknown, maybe some sub-library that is used has changed? I have no clue. Meaning it runs ok locally seems to be no guarantee it will look the same when run by the CI :-( Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
|
@Finii thanks a lot man!! Really appreciate it, lemme know if you need any sorts of help any time :) |
LNKLEO
pushed a commit
to LNKLEO/Nerd
that referenced
this pull request
Nov 24, 2023
[why] The CI process produces a different font than running the generate-original-source script locally. Several thing have been checked, to no avail, see ryanoasis#1227. Turned out the affected SVGs all are somehow ... questionable in their construction. [how] Open SVGs in inkscape, select all (points) and generate new, clean outline with Path->Union. Save as optimized SVG. The (CI) created font file now looks good. But the cause is still unknown, maybe some sub-library that is used has changed? I have no clue. Meaning it runs ok locally seems to be no guarantee it will look the same when run by the CI :-( Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
nf-oct-file_directorytonf-custom-file_directory.Requirements / Checklist
What does this Pull Request (PR) do?
How should this be manually tested?
Any background context you can provide?
What are the relevant tickets (if any)?
Screenshots (if appropriate or helpful)