-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update postgres docker tag to v16.4 - abandoned #2012
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* Add .npmrc file with node-options="--openssl-legacy-provider" Delete .eslintignore file Add tsconfig.eslint.json file with specific compiler options Update vite.config.ts file to include "pool: forks" Add eslint.config.js file with eslint and typescript-eslint configurations Delete .eslintrc.json file Update .github/workflows/node.yml file to use "pnpm build" and "npm test" Update packages/gateway/test/web.test.ts file to use double quotes Update package.json file with lint, start, format, and test scripts * Update eslint.config.js file with eslint and typescript-eslint configurations * Update eslint.config.js with eslint and typescript-eslint configurations * Update .gitattributes file to prevent merging changes to generated files * Update codecovcli command in .github/workflows/node.yml
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* add logging to triage 1902 Related Error: Error handling packet: error: relation "vehicle" does not exist #1902 * Add TServerLogger type to mockLogger function * Fix unused import and remove eslint-disable-next-line in State.ts
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- docker-compose.yml (1 hunks)
Additional comments not posted (1)
docker-compose.yml (1)
14-14
: Update approved: Verify compatibility and test thoroughly.The PostgreSQL Docker image version has been updated from
16.3
to16.4
. Ensure that this new version is compatible with your application and test thoroughly for any breaking changes or new features that might affect the system's behavior.Verification successful
No specific configurations for PostgreSQL 16.4 found; ensure thorough testing.
The update to PostgreSQL 16.4 in
docker-compose.yml
does not appear to have any associated version-specific configurations or documentation in the repository. It is recommended to conduct comprehensive testing to ensure compatibility and catch any potential issues.
- Verify application behavior with PostgreSQL 16.4.
- Check for any deprecations or changes in PostgreSQL 16.4 that might affect your application.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify compatibility of PostgreSQL 16.4 with the application. # Test: Check for PostgreSQL version-specific configurations or migrations. rg --type yaml 'postgres:16.4'Length of output: 150
Script:
#!/bin/bash # Search for any version-specific configurations or documentation related to PostgreSQL 16.4 rg '16.4' -A 5Length of output: 7060
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- docker-compose.yml (1 hunks)
Additional comments not posted (1)
docker-compose.yml (1)
14-14
: Ensure compatibility with PostgreSQL 16.4.The PostgreSQL image version has been updated to
16.4
. Ensure that this version is compatible with your application and test it thoroughly in both local and staging environments before deploying to production.
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #2012 +/- ##
=======================================
Coverage 10.51% 10.51%
=======================================
Files 97 97
Lines 8503 8503
Branches 102 106 +4
=======================================
Hits 894 894
Misses 7609 7609
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
6dabb26
to
513ef60
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CodecovAI submitted a new review for 513ef60
docker-compose.yml
Outdated
@@ -11,7 +11,7 @@ services: | |||
extra_hosts: | |||
- "host.docker.internal:host-gateway" | |||
db: | |||
image: postgres:16.3@sha256:0aafd2ae7e6c391f39fb6b7621632d79f54068faebc726caf469e87bd1d301c0 | |||
image: postgres:16.4@sha256:0cf02e45421b780449f0bab6b4af7e5ab2c37d3ca729e284fcec1a18f3fa9354 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good update as it specifies a new Docker image version for the PostgreSQL database. It's always good to keep our base images up-to-date for the sake of getting the latest security patches and improvements. However, I suggest testing the application with the updated image before deploying it to production, because even minor version upgrades can introduce breaking changes and you should ensure it doesn't negatively affect the application.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CodecovAI submitted a new review for 513ef60
docker-compose.yml
Outdated
@@ -11,7 +11,7 @@ services: | |||
extra_hosts: | |||
- "host.docker.internal:host-gateway" | |||
db: | |||
image: postgres:16.3@sha256:0aafd2ae7e6c391f39fb6b7621632d79f54068faebc726caf469e87bd1d301c0 | |||
image: postgres:16.4@sha256:0cf02e45421b780449f0bab6b4af7e5ab2c37d3ca729e284fcec1a18f3fa9354 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have updated the PostgreSQL's version from 16.3 to 16.4 in image hash. Please ensure to conduct tests for not breaking our existing database. Upgrading directly may lead to incompatibilities.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- docker-compose.yml (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- docker-compose.yml
513ef60
to
25475a3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CodecovAI submitted a new review for 25475a3
docker-compose.yml
Outdated
@@ -11,7 +11,7 @@ services: | |||
extra_hosts: | |||
- "host.docker.internal:host-gateway" | |||
db: | |||
image: postgres:16.3@sha256:0aafd2ae7e6c391f39fb6b7621632d79f54068faebc726caf469e87bd1d301c0 | |||
image: postgres:16.4@sha256:099dbb13112c133b37463fd312d3134aabfd5b3db3846f2f336b2996a9566bec |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The hash of the docker image is hard-coded here, which can reduce the flexibility of updating or patching this image. I would advise using a separate configuration file to store these specific details. This would improve the maintainability of your code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- docker-compose.yml (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- docker-compose.yml
25475a3
to
00c7e18
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CodecovAI submitted a new review for 00c7e18
docker-compose.yml
Outdated
@@ -11,7 +11,7 @@ services: | |||
extra_hosts: | |||
- "host.docker.internal:host-gateway" | |||
db: | |||
image: postgres:16.3@sha256:0aafd2ae7e6c391f39fb6b7621632d79f54068faebc726caf469e87bd1d301c0 | |||
image: postgres:16.4@sha256:66f4449a14d6351be5750b97e32fec03ab92256a1294330e4a2868107b5ddff5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before changing the Postgres image from version 16.3 to 16.4, make sure to properly test the new version with your application to ensure it doesn't introduce any incompatibilities or regressions. Also, you need to check the migration path if any, from the official documentation. If your database has any data, remember to create a backup before proceeding with the upgrade as a preventive measure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- docker-compose.yml (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- docker-compose.yml
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [sentry-sdk](https://github.com/getsentry/sentry-python) ([changelog](https://github.com/getsentry/sentry-python/blob/master/CHANGELOG.md)) | `==2.12.0` -> `==2.13.0` | [![age](https://developer.mend.io/api/mc/badges/age/pypi/sentry-sdk/2.13.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/pypi/sentry-sdk/2.13.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/pypi/sentry-sdk/2.12.0/2.13.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/pypi/sentry-sdk/2.12.0/2.13.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>getsentry/sentry-python (sentry-sdk)</summary> ### [`v2.13.0`](https://github.com/getsentry/sentry-python/blob/HEAD/CHANGELOG.md#2130) [Compare Source](https://github.com/getsentry/sentry-python/compare/2.12.0...2.13.0) ##### Various fixes & improvements - **New integration:** [Ray](https://docs.sentry.io/platforms/python/integrations/ray/) ([#​2400](https://github.com/getsentry/sentry-python/issues/2400)) ([#​2444](https://github.com/getsentry/sentry-python/issues/2444)) by [@​glowskir](https://github.com/glowskir) Usage: (add the RayIntegration to your `sentry_sdk.init()` call and make sure it is called in the worker processes) ```python import ray import sentry_sdk from sentry_sdk.integrations.ray import RayIntegration def init_sentry(): sentry_sdk.init( dsn="...", traces_sample_rate=1.0, integrations=[RayIntegration()], ) init_sentry() ray.init( runtime_env=dict(worker_process_setup_hook=init_sentry), ) ``` For more information, see the documentation for the [Ray integration](https://docs.sentry.io/platforms/python/integrations/ray/). - **New integration:** [Litestar](https://docs.sentry.io/platforms/python/integrations/litestar/) ([#​2413](https://github.com/getsentry/sentry-python/issues/2413)) ([#​3358](https://github.com/getsentry/sentry-python/issues/3358)) by [@​KellyWalker](https://github.com/KellyWalker) Usage: (add the LitestarIntegration to your `sentry_sdk.init()`) ```python from litestar import Litestar, get import sentry_sdk from sentry_sdk.integrations.litestar import LitestarIntegration sentry_sdk.init( dsn="...", traces_sample_rate=1.0, integrations=[LitestarIntegration()], ) @​get("/") async def index() -> str: return "Hello, world!" app = Litestar(...) ``` For more information, see the documentation for the [Litestar integration](https://docs.sentry.io/platforms/python/integrations/litestar/). - **New integration:** [Dramatiq](https://docs.sentry.io/platforms/python/integrations/dramatiq/) from [@​jacobsvante](https://github.com/jacobsvante) ([#​3397](https://github.com/getsentry/sentry-python/issues/3397)) by [@​antonpirker](https://github.com/antonpirker) Usage: (add the DramatiqIntegration to your `sentry_sdk.init()`) ```python import dramatiq import sentry_sdk from sentry_sdk.integrations.dramatiq import DramatiqIntegration sentry_sdk.init( dsn="...", traces_sample_rate=1.0, integrations=[DramatiqIntegration()], ) @​dramatiq.actor(max_retries=0) def dummy_actor(x, y): return x / y dummy_actor.send(12, 0) ``` For more information, see the documentation for the [Dramatiq integration](https://docs.sentry.io/platforms/python/integrations/dramatiq/). - **New config option:** Expose `custom_repr` function that precedes `safe_repr` invocation in serializer ([#​3438](https://github.com/getsentry/sentry-python/issues/3438)) by [@​sl0thentr0py](https://github.com/sl0thentr0py) See: https://docs.sentry.io/platforms/python/configuration/options/#custom-repr - Profiling: Add client SDK info to profile chunk ([#​3386](https://github.com/getsentry/sentry-python/issues/3386)) by [@​Zylphrex](https://github.com/Zylphrex) - Serialize vars early to avoid living references ([#​3409](https://github.com/getsentry/sentry-python/issues/3409)) by [@​sl0thentr0py](https://github.com/sl0thentr0py) - Deprecate hub-based `sessions.py` logic ([#​3419](https://github.com/getsentry/sentry-python/issues/3419)) by [@​szokeasaurusrex](https://github.com/szokeasaurusrex) - Deprecate `is_auto_session_tracking_enabled` ([#​3428](https://github.com/getsentry/sentry-python/issues/3428)) by [@​szokeasaurusrex](https://github.com/szokeasaurusrex) - Add note to generated yaml files ([#​3423](https://github.com/getsentry/sentry-python/issues/3423)) by [@​sentrivana](https://github.com/sentrivana) - Slim down PR template ([#​3382](https://github.com/getsentry/sentry-python/issues/3382)) by [@​sentrivana](https://github.com/sentrivana) - Use new banner in readme ([#​3390](https://github.com/getsentry/sentry-python/issues/3390)) by [@​sentrivana](https://github.com/sentrivana) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/rustymotors/server-old). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzguMjYuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->
00c7e18
to
47fd9c9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CodecovAI submitted a new review for 47fd9c9
docker-compose.yml
Outdated
@@ -11,7 +11,7 @@ services: | |||
extra_hosts: | |||
- "host.docker.internal:host-gateway" | |||
db: | |||
image: postgres:16.3@sha256:0aafd2ae7e6c391f39fb6b7621632d79f54068faebc726caf469e87bd1d301c0 | |||
image: postgres:16.4@sha256:184c301e214615e4202e51a98ebf7e2d46325a6f1cdc2ff9c30bdde516657876 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is important to note the change in the SHA256 hash, which verifies that the downloaded files are the correct ones and haven't been tampered with. This change should be expected when updating to a different image version.
@@ -11,7 +11,7 @@ services: | |||
extra_hosts: | |||
- "host.docker.internal:host-gateway" | |||
db: | |||
image: postgres:16.3@sha256:0aafd2ae7e6c391f39fb6b7621632d79f54068faebc726caf469e87bd1d301c0 | |||
image: postgres:16.4@sha256:184c301e214615e4202e51a98ebf7e2d46325a6f1cdc2ff9c30bdde516657876 | |||
restart: always |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 'restart: always' policy means that if the container exits for any reason, Docker will restart it. If the update to version 16.4 fails for any reason, Docker will continually try to restart the container, potentially leading to resource draining.
@@ -11,7 +11,7 @@ services: | |||
extra_hosts: | |||
- "host.docker.internal:host-gateway" | |||
db: | |||
image: postgres:16.3@sha256:0aafd2ae7e6c391f39fb6b7621632d79f54068faebc726caf469e87bd1d301c0 | |||
image: postgres:16.4@sha256:184c301e214615e4202e51a98ebf7e2d46325a6f1cdc2ff9c30bdde516657876 | |||
restart: always | |||
environment: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure to double-check the possibility of any environment variable changes that might be impacted by the Postgres update. New variables might need to be considered or old ones might become obsolete.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- docker-compose.yml (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- docker-compose.yml
47fd9c9
to
d3e5a14
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CodecovAI submitted a new review for d3e5a14
docker-compose.yml
Outdated
@@ -11,7 +11,7 @@ services: | |||
extra_hosts: | |||
- "host.docker.internal:host-gateway" | |||
db: | |||
image: postgres:16.3@sha256:0aafd2ae7e6c391f39fb6b7621632d79f54068faebc726caf469e87bd1d301c0 | |||
image: postgres:16.4@sha256:59c554e6f26822fd489ebbdef431457db2debd0c5762b24f11f603db5b91dfcc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While upgrading a database is often beneficial, have we considered potential issues that may arise from this upgrade? To ensure smooth migration, we should verify if the application's existing database interactions are compatible with Postgres 16.4. Also, it would help to specify the rationale for the upgrade in a comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- docker-compose.yml (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- docker-compose.yml
d3e5a14
to
a8f8a7f
Compare
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CodecovAI submitted a new review for a8f8a7f
@@ -11,7 +11,7 @@ services: | |||
extra_hosts: | |||
- "host.docker.internal:host-gateway" | |||
db: | |||
image: postgres:16.3@sha256:0aafd2ae7e6c391f39fb6b7621632d79f54068faebc726caf469e87bd1d301c0 | |||
image: postgres:16.4@sha256:c62fdb7fd6f519ef425c54760894c74e8d0cb04fbf4f7d3d79aafd86bae24edd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have updated the docker image used for the postgres service to a newer version. Please make sure if the corresponding Dockerfile (if any) of any services, CSRF tokens or any other database entities are also updated in the concerned repositories to ensure smooth operation and avoid unexpected behaviour.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- docker-compose.yml (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- docker-compose.yml
Autoclosing SkippedThis PR has been flagged for autoclosing. However, it is being skipped due to the branch being already modified. Please close/delete it manually or report a bug if you think this is in error. |
This PR contains the following updates:
16.3
->16.4
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.