Add .npmrc file with node-options="--openssl-legacy-provider" #1887

drazisil · 2024-04-13T23:20:15Z

Delete .eslintignore file
Add tsconfig.eslint.json file with specific compiler options
Update vite.config.ts file to include "pool: forks"
Add eslint.config.js file with eslint and typescript-eslint configurations
Delete .eslintrc.json file
Update .github/workflows/node.yml file to use "pnpm build" and "npm test"
Update packages/gateway/test/web.test.ts file to use double quotes
Update package.json file with lint, start, format, and test scripts

Summary by CodeRabbit

New Features
- Introduced TypeScript linting with ESLint.
- Added new formatting script for code standardization.
Improvements
- Updated build and test workflows for better performance.
- Enhanced test configurations and scripts for more comprehensive coverage.
Bug Fixes
- Corrected string comparison in test cases to ensure consistency.
Refactor
- Streamlined start script by removing outdated flags.

Delete .eslintignore file Add tsconfig.eslint.json file with specific compiler options Update vite.config.ts file to include "pool: forks" Add eslint.config.js file with eslint and typescript-eslint configurations Delete .eslintrc.json file Update .github/workflows/node.yml file to use "pnpm build" and "npm test" Update packages/gateway/test/web.test.ts file to use double quotes Update package.json file with lint, start, format, and test scripts

coderabbitai · 2024-04-13T23:20:22Z

Warning

Rate Limit Exceeded

@drazisil has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 8 minutes and 53 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 3bf133e and c80592b.

Walkthrough

The recent updates aim to enhance the development environment by optimizing build and test processes, enforcing code style with TypeScript linting, and improving performance and compatibility. Notable changes include adopting pnpm for building and linting, integrating TypeScript with ESLint, and updating configurations in npm and Vite for better functionality.

Changes

File(s)	Change Summary
`.github/workflows/node.yml`	Replaced build and test commands with `pnpm build` and `npm test`.
`.npmrc`, `package.json`	Introduced `--openssl-legacy-provider`; updated scripts.
`eslint.config.js`, `tsconfig.eslint.json`	Added TypeScript linting; adjusted ESLint and tsconfig settings.
`package.json`	Added `@eslint/js`, `typescript-eslint` to devDependencies.
`packages/gateway/test/web.test.ts`	Updated string comparison in test cases.
`vite.config.ts`	Added `pool: "forks"` configuration in Vite settings.

🐇✨
In the code's meadow, under the bright moonlight,
A rabbit hops with glee, for the code is just right.
With a flick of its tail, and a twitch of its ear,
Celebrates the changes, clear and sincere.
"Hop, hop, hooray!" it cheers with delight, 🌟
For the code now runs swift, into the night.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

codecov · 2024-04-13T23:20:34Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.50%. Comparing base (155c18b) to head (c80592b).

✅ All tests successful. No failed tests found ☺️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1887   +/-   ##
=======================================
  Coverage   42.50%   42.50%           
=======================================
  Files          83       83           
  Lines       10329    10329           
  Branches       97      119   +22     
=======================================
  Hits         4390     4390           
  Misses       5939     5939

Flag	Coverage Δ
core	`100.00% <ø> (ø)`
database	`14.21% <ø> (ø)`
gateway	`46.84% <ø> (ø)`
lobby	`32.69% <ø> (ø)`
login	`24.06% <ø> (ø)`
patch	`87.28% <ø> (ø)`
persona	`27.94% <ø> (ø)`
shard	`96.87% <ø> (ø)`
transactions	`52.52% <ø> (ø)`

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

socket-security · 2024-04-13T23:20:36Z

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@eslint/js@9.0.0	None	`0`	13.9 kB	eslintbot
npm/typescript-eslint@7.6.0	Transitive: environment, filesystem	`+48`	8.35 MB	jameshenry

View full report↗︎

deepsource-io · 2024-04-13T23:20:43Z

Here's the code health analysis summary for commits 155c18b..c80592b. View details on DeepSource ↗.

Analysis Summary

Analyzer	Status	Summary	Link
JavaScript	✅ Success		View Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

coderabbitai

Actionable comments posted: 1

coderabbitai · 2024-04-13T23:23:09Z

eslint.config.js

+// @ts-check
+
+import eslint from '@eslint/js';
+import tseslint from 'typescript-eslint';
+
+export default tseslint.config(
+  eslint.configs.recommended,
+  ...tseslint.configs.recommended,
+);


The ESLint configuration with TypeScript support is correctly set up. However, the file needs formatting adjustments.

- // @ts-check + // @ts-check

Run trunk fmt to autoformat the file.

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change

// @ts-check

import eslint from '@eslint/js';

import tseslint from 'typescript-eslint';

export default tseslint.config(

eslint.configs.recommended,

...tseslint.configs.recommended,

);

// @ts-check

import eslint from '@eslint/js';

import tseslint from 'typescript-eslint';

export default tseslint.config(

eslint.configs.recommended,

...tseslint.configs.recommended,

);

…urations

coderabbitai

Actionable comments posted: 1

coderabbitai · 2024-04-13T23:30:26Z

eslint.config.js

@@ -0,0 +1,9 @@
+// @ts-check


Run trunk fmt to autoformat the file for correct formatting.

sonarcloud · 2024-04-13T23:41:54Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

pull-request-size bot added the size/L label Apr 13, 2024

coderabbitai bot reviewed Apr 13, 2024

View reviewed changes

Update eslint.config.js file with eslint and typescript-eslint config…

e5eaa3d

…urations

coderabbitai bot reviewed Apr 13, 2024

View reviewed changes

eslint.config.js

@@ -0,0 +1,9 @@

// @ts-check

Copy link

coderabbitai bot Apr 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run trunk fmt to autoformat the file for correct formatting.

drazisil added 3 commits April 13, 2024 19:31

Update eslint.config.js with eslint and typescript-eslint configurations

3bf133e

Update .gitattributes file to prevent merging changes to generated files

27c18bb

Update codecovcli command in .github/workflows/node.yml

c80592b

drazisil merged commit 7c34644 into main Apr 13, 2024
14 checks passed

drazisil deleted the patch-0 branch April 13, 2024 23:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add .npmrc file with node-options="--openssl-legacy-provider" #1887

Add .npmrc file with node-options="--openssl-legacy-provider" #1887

drazisil commented Apr 13, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Apr 13, 2024 •

edited

Loading

Rate Limit Exceeded

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

codecov bot commented Apr 13, 2024 •

edited

Loading

socket-security bot commented Apr 13, 2024 •

edited

Loading

deepsource-io bot commented Apr 13, 2024 •

edited

Loading

Analysis Summary

coderabbitai bot left a comment

coderabbitai bot Apr 13, 2024

coderabbitai bot left a comment

coderabbitai bot Apr 13, 2024

sonarcloud bot commented Apr 13, 2024

Add .npmrc file with node-options="--openssl-legacy-provider" #1887

Add .npmrc file with node-options="--openssl-legacy-provider" #1887

Conversation

drazisil commented Apr 13, 2024 • edited by coderabbitai bot Loading

Summary by CodeRabbit

coderabbitai bot commented Apr 13, 2024 • edited Loading

Rate Limit Exceeded

Walkthrough

Changes

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

codecov bot commented Apr 13, 2024 • edited Loading

Codecov Report

socket-security bot commented Apr 13, 2024 • edited Loading

deepsource-io bot commented Apr 13, 2024 • edited Loading

Analysis Summary

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot Apr 13, 2024

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot Apr 13, 2024

Choose a reason for hiding this comment

sonarcloud bot commented Apr 13, 2024

Quality Gate passed

drazisil commented Apr 13, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Apr 13, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)

codecov bot commented Apr 13, 2024 •

edited

Loading

socket-security bot commented Apr 13, 2024 •

edited

Loading

deepsource-io bot commented Apr 13, 2024 •

edited

Loading