Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly consume tokens when parsing js_namespace #2510

Merged
merged 3 commits into from
Mar 29, 2021
Merged

Correctly consume tokens when parsing js_namespace #2510

merged 3 commits into from
Mar 29, 2021

Commits on Mar 29, 2021

  1. Correctly consume tokens when parsing js_namespace 

    `syn` < 1.0.66 would consume the `AnyIdent` anyway while trying to parse
the `ExprArray`.

Now due to a refactoring they did, they (correctly) leave the `ParseBuffer`
untouched if the input is not a valid `ExprArray`, so we should avoid forking
the input buffer and just use the same for both tries, otherwise the unwanted
tokens left in there would make `Punctuated` break soon after.

Fixes rustwasm#2508
    @afilini
    afilini committed Mar 29, 2021
    Configuration menu
    Copy the full SHA
    e26f57d View commit details
    Browse the repository at this point in the history

  2. Update nightly used on CI

    @alexcrichton
    alexcrichton committed Mar 29, 2021
    Configuration menu
    Copy the full SHA
    0cf36e6 View commit details
    Browse the repository at this point in the history

  3. Update syn version dependency

    @alexcrichton
    alexcrichton committed Mar 29, 2021
    Configuration menu
    Copy the full SHA
    94b119f View commit details
    Browse the repository at this point in the history