Correctly consume tokens when parsing js_namespace
#2510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`syn` < 1.0.66 would consume the `AnyIdent` anyway while trying to parse the `ExprArray`. Now due to a refactoring they did, they (correctly) leave the `ParseBuffer` untouched if the input is not a valid `ExprArray`, so we should avoid forking the input buffer and just use the same for both tries, otherwise the unwanted tokens left in there would make `Punctuated` break soon after. Fixes rustwasm#2508
|
You need to bump the nightly version here it seems (why is it pinned like this in the first place? seems odd): wasm-bindgen/azure-pipelines.yml Line 90 in 0cec406 Additionally wouldn't it make sense to also depend on the new syn if the old one had a bug (not sure I understand the problem with syn enough) |
|
Thanks for the report and the PR! I've pushed up a few extra commits to fix CI and also update the |
bors bot
pushed a commit
to bevyengine/bevy
that referenced
this pull request
Mar 30, 2021
This is a temporary fix for the CI (and anyone building for wasm) break until `wgpu` can update * `syn` released a version that fixed a bug in how they parsed attributes * `wasm_bindgen` released a version that uses that fix * but we're stuck with old `wasm_bindgen` as `wgpu` uses a fixed version: https://github.com/gfx-rs/wgpu-rs/blob/c5ee9cd98310aee66fb49bc98f4f65590304e4aa/Cargo.toml#L118 So, to fix this, either we update everyone to latest version of `wasm_bindgen` or we keep using old version of `syn`. On Bevy side, it should be faster to fix the version of `syn` to one that works. More details: rustwasm/wasm-bindgen#2510 & rustwasm/wasm-bindgen#2508
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
syn< 1.0.66 would consume theAnyIdentanyway while trying to parse theExprArray.Now due to a refactoring they did, they (correctly) leave the
ParseBufferuntouched if the input is not a validExprArray, so we should avoid forking the input buffer and just use the same for both tries, otherwise the unwanted tokens left in there would makePunctuatedbreak soon after.Fixes #2508