Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parse: recover mut (x @ y) as (mut x @ mut y). #69236

Merged
merged 1 commit into from
Feb 19, 2020
Merged

parse: recover mut (x @ y) as (mut x @ mut y). #69236

merged 1 commit into from
Feb 19, 2020

Conversation

Centril
Copy link
Contributor

@Centril Centril commented Feb 17, 2020

Follow up to #68992 (comment) and #63945.

Specifically, when given let mut (x @ y) we recover with let (mut x @ mut y) as the suggestion:

error: `mut` must be attached to each individual binding
  --> $DIR/mut-patterns.rs:12:9
   |
LL |     let mut (x @ y) = 0;
   |         ^^^^^^^^^^^ help: add `mut` to each binding: `(mut x @ mut y)`
   |
   = note: `mut` may be followed by `variable` and `variable @ pattern`

r? @matthewjasper @estebank

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 17, 2020
@Centril Centril added the F-bindings_after_at `#![feature(bindings_after_at)]` label Feb 17, 2020
@Centril Centril mentioned this pull request Feb 17, 2020
Merged
@estebank
Copy link
Contributor

R=me

@Centril
Copy link
Contributor Author

Centril commented Feb 17, 2020

@bors r=estebank

@bors
Copy link
Contributor

bors commented Feb 17, 2020

📌 Commit 0b1e08c has been approved by estebank

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 17, 2020
@Centril
Copy link
Contributor Author

Centril commented Feb 17, 2020

r? @estebank

Centril added a commit to Centril/rust that referenced this pull request Feb 18, 2020
@Centril
Rollup merge of rust-lang#69236 - Centril:mut-parens-at-recovery, r=e…
6c6d45c 
…stebank

parse: recover `mut (x @ y)` as `(mut x @ mut y)`.

Follow up to rust-lang#68992 (comment) and rust-lang#63945.

Specifically, when given `let mut (x @ y)` we recover with `let (mut x @ mut y)` as the suggestion:

```rust
error: `mut` must be attached to each individual binding
  --> $DIR/mut-patterns.rs:12:9
   |
LL |     let mut (x @ y) = 0;
   |         ^^^^^^^^^^^ help: add `mut` to each binding: `(mut x @ mut y)`
   |
   = note: `mut` may be followed by `variable` and `variable @ pattern`
```

r? @matthewjasper @estebank
@Centril Centril mentioned this pull request Feb 18, 2020
Merged
bors added a commit that referenced this pull request Feb 18, 2020
@bors
Auto merge of #69271 - Centril:rollup-iupsol6, r=Centril
e0e5d82 
Rollup of 6 pull requests

Successful merges:

 - #69146 (Always const qualify literals by type)
 - #69159 (Select an appropriate unused lifetime name in suggestion)
 - #69194 (parse: fuse associated and extern items up to defaultness)
 - #69211 (parser: Simplify treatment of macro variables in `Parser::bump`)
 - #69217 (Do not emit note suggesting to implement operation trait to foreign type)
 - #69236 (parse: recover `mut (x @ y)` as `(mut x @ mut y)`.)

Failed merges:

r? @ghost
@bors bors merged commit 0b1e08c into rust-lang:master Feb 19, 2020
@Centril Centril deleted the mut-parens-at-recovery branch February 20, 2020 17:23
@Centril Centril mentioned this pull request Feb 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@estebank estebank

Labels
F-bindings_after_at `#![feature(bindings_after_at)]` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Centril @estebank @bors @rust-highfive @matthewjasper