Select an appropriate unused lifetime name in suggestion #69159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
cc @nagisa, this is the missing bit from that suggestion to make it always "right". |
estebank
force-pushed
the
use-appropriate-lt-name
branch
from
b762a9c
to
5f43d8b
Compare
|
This seems good other than a small typo in the new comment. r=me unless you want nagisa to take a look. |
estebank
force-pushed
the
use-appropriate-lt-name
branch
from
5f43d8b
to
0ee27ee
Compare
|
@bors r=ecstatic-morse |
|
📌 Commit 0ee27eeda1bd585fe91fa2b8673c44b9569e1721 has been approved by |
bors
added
S-waiting-on-bors
|
☔ The latest upstream changes (presumably #67681) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
estebank
force-pushed
the
use-appropriate-lt-name
branch
from
0ee27ee
to
8bafe88
Compare
|
@bors r=ecstatic-morse |
|
📌 Commit 8bafe88 has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Feb 17, 2020
…=ecstatic-morse Select an appropriate unused lifetime name in suggestion Follow up to rust-lang#69048.
Centril
added a commit
to Centril/rust
that referenced
this pull request
Feb 18, 2020
…=ecstatic-morse Select an appropriate unused lifetime name in suggestion Follow up to rust-lang#69048.
bors
added a commit
that referenced
this pull request
Feb 18, 2020
Rollup of 6 pull requests Successful merges: - #69146 (Always const qualify literals by type) - #69159 (Select an appropriate unused lifetime name in suggestion) - #69194 (parse: fuse associated and extern items up to defaultness) - #69211 (parser: Simplify treatment of macro variables in `Parser::bump`) - #69217 (Do not emit note suggesting to implement operation trait to foreign type) - #69236 (parse: recover `mut (x @ y)` as `(mut x @ mut y)`.) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #69048.