Export public scalar statics in wasm #67975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
26 tasks
|
I think that the case for wasm can be removed entirely here since I believe the exported value is always the address of the variable in memory |
|
I think that this is probably ok to land, but can you add some wasm-specific tests (probably around |
MaikKlein
force-pushed
the
export-statics-wasm
branch
from
474b108
to
eddb3f0
Compare
MaikKlein
force-pushed
the
export-statics-wasm
branch
from
eddb3f0
to
093fb85
Compare
|
Added a very basic test to |
|
@bors: r+ Nice! |
|
📌 Commit f1fb384 has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jan 9, 2020
…r=alexcrichton Export public scalar statics in wasm Fixes rust-lang#67453 I am not sure which export level statics should get when exporting them in wasm. This small change fixes the issue that I had, but this might not be the correct way to implement this.
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jan 9, 2020
…r=alexcrichton Export public scalar statics in wasm Fixes rust-lang#67453 I am not sure which export level statics should get when exporting them in wasm. This small change fixes the issue that I had, but this might not be the correct way to implement this.
bors
added a commit
that referenced
this pull request
Jan 9, 2020
Rollup of 6 pull requests Successful merges: - #67258 (Introduce `X..`, `..X`, and `..=X` range patterns) - #67358 (Add HashSet::get_or_insert_owned) - #67935 (Relax the Sized bounds on Pin::map_unchecked(_mut)) - #67975 (Export public scalar statics in wasm) - #67988 (Change -Z time event naming scheme and make them generic activities) - #68006 (Recognise riscv64 in compiletest) Failed merges: - #67806 (Extract `rustc_ast_passes`, move gating, & refactor linting) r? @ghost
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Jan 9, 2020
…r=alexcrichton Export public scalar statics in wasm Fixes rust-lang#67453 I am not sure which export level statics should get when exporting them in wasm. This small change fixes the issue that I had, but this might not be the correct way to implement this.
bors
added a commit
that referenced
this pull request
Jan 9, 2020
Rollup of 10 pull requests Successful merges: - #66254 (Make Layout::new const) - #67122 (Do not deduplicate diagnostics in UI tests) - #67358 (Add HashSet::get_or_insert_owned) - #67725 (Simplify into_key_slice_mut) - #67935 (Relax the Sized bounds on Pin::map_unchecked(_mut)) - #67967 (Delay bug to prevent ICE in MIR borrowck) - #67975 (Export public scalar statics in wasm) - #68006 (Recognise riscv64 in compiletest) - #68040 (Cleanup) - #68054 (doc: add Null-unchecked version section to mut pointer as_mut method) Failed merges: - #67258 (Introduce `X..`, `..X`, and `..=X` range patterns) r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #67453
I am not sure which export level statics should get when exporting them in wasm. This small change fixes the issue that I had, but this might not be the correct way to implement this.