Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Beta rollups #58656

Merged
merged 13 commits into from
Feb 23, 2019
Merged

Beta rollups #58656

merged 13 commits into from
Feb 23, 2019

Commits on Feb 22, 2019

  1. Fix rust-lang#57979 by allowing a legitimate type error to take prece… 

    …dence over an ICE.
    @pnkfelix @Mark-Simulacrum
    pnkfelix authored and Mark-Simulacrum committed Feb 22, 2019
    Configuration menu
    Copy the full SHA
    f22755f View commit details
    Browse the repository at this point in the history

  2. make generalization code create new variables in correct universe 

    In our type inference system, when we "generalize" a type T to become
a suitable value for a type variable V, we sometimes wind up creating
new inference variables. So, for example, if we are making V be some
subtype of `&'X u32`, then we might instantiate V with `&'Y u32`.
This generalized type is then related `&'Y u32 <: &'X u32`, resulting
in a region constriant `'Y: 'X`. Previously, however, we were making
these fresh variables like `'Y` in the "current universe", but they
should be created in the universe of V. Moreover, we sometimes cheat
in an invariant context and avoid creating fresh variables if we know
the result must be equal -- we can only do that when the universes
work out.
    @nikomatsakis
    nikomatsakis committed Feb 22, 2019
    Configuration menu
    Copy the full SHA
    687c449 View commit details
    Browse the repository at this point in the history

  3. s/skol_/placeholder_/

    @nikomatsakis
    nikomatsakis committed Feb 22, 2019
    Configuration menu
    Copy the full SHA
    f599ab6 View commit details
    Browse the repository at this point in the history

  4. reintroduce commit_if_ok call into higher_ranked_sub

    @nikomatsakis
    nikomatsakis committed Feb 22, 2019
    Configuration menu
    Copy the full SHA
    4916c8f View commit details
    Browse the repository at this point in the history

  5. reintroduce commit_if_ok calls to subtype_predicate

    @nikomatsakis
    nikomatsakis committed Feb 22, 2019
    Configuration menu
    Copy the full SHA
    2a8c36c View commit details
    Browse the repository at this point in the history

  6. introduce a dummy leak check and invoke it in all the right places 

    This set of diffs was produced by combing through
b68fad6 and seeing where the
`leak_check` used to be invoked and how.
    @nikomatsakis
    nikomatsakis committed Feb 22, 2019
    Configuration menu
    Copy the full SHA
    3693f18 View commit details
    Browse the repository at this point in the history

  7. restore the actual leak-check

    @nikomatsakis
    nikomatsakis committed Feb 22, 2019
    Configuration menu
    Copy the full SHA
    85a24b1 View commit details
    Browse the repository at this point in the history

  8. update test files to reflect new output 

    One surprise: old-lub-glb-object.rs, may indicate a bug
    @nikomatsakis
    nikomatsakis committed Feb 22, 2019
    Configuration menu
    Copy the full SHA
    542ad5e View commit details
    Browse the repository at this point in the history

  9. partially revert 904a0bd 

    This preserves the error you currently get on stable for the
old-lub-glb-object.rs test.
    @nikomatsakis
    nikomatsakis committed Feb 22, 2019
    Configuration menu
    Copy the full SHA
    551aafc View commit details
    Browse the repository at this point in the history

  10. improve Pin documentation 

    Incorporates a bunch of the documentation-related comments that came up when discussing `Pin` stabilization.
    @RalfJung @nikomatsakis
    RalfJung authored and nikomatsakis committed Feb 22, 2019
    Configuration menu
    Copy the full SHA
    600ca1e View commit details
    Browse the repository at this point in the history

  11. Updated RELEASES.md for 1.33.0 

    Cherry-picked (and squashed) from rust-lang#58227.
    @nikomatsakis
    Aaron Power authored and nikomatsakis committed Feb 22, 2019
    1 Configuration menu
    Copy the full SHA
    fdd5467 View commit details
    Browse the repository at this point in the history

  12. Fix invalid background color

    @GuillaumeGomez @nikomatsakis
    GuillaumeGomez authored and nikomatsakis committed Feb 22, 2019
    Configuration menu
    Copy the full SHA
    a63575c View commit details
    Browse the repository at this point in the history

  13. Fix non-clickable urls

    @GuillaumeGomez @nikomatsakis
    GuillaumeGomez authored and nikomatsakis committed Feb 22, 2019
    Configuration menu
    Copy the full SHA
    5c6eb4e View commit details
    Browse the repository at this point in the history