Updated RELEASES.md for 1.33.0 #58227

XAMPPRocky · 2019-02-06T14:47:11Z

Rendered

r? @Mark-Simulacrum

cc @rust-lang/release

RELEASES.md

Co-Authored-By: Aaronepower <Aaronepower@users.noreply.github.com>

RELEASES.md

imp · 2019-02-12T09:29:12Z

Shouldn't this mention a deprecation for trim_left, trim_right, trim_left_matches and trim_right_matches?

Co-Authored-By: Aaronepower <Aaronepower@users.noreply.github.com>

RELEASES.md

tesuji · 2019-02-12T18:05:30Z

I think using passive voice is more appropriate. For example, change

You can now import an item from a module as an _.

to

Item from a module can now be imported as an _.

Centril · 2019-02-12T19:22:45Z

We use active voice everywhere else so we should stick to it; moreover, if you say "Item..." you need to say "An item..." or "Items from modules...".

Co-Authored-By: Aaronepower <Aaronepower@users.noreply.github.com>

XAMPPRocky · 2019-02-13T12:41:05Z

@lzutao Using an active voice also more clearly shows that the RELEASES.md document is an editorialized list of what the Rust team thinks people should know about, which is not definitive list of every contribution to the release itself.

RELEASES.md

Co-Authored-By: Aaronepower <Aaronepower@users.noreply.github.com>

RELEASES.md

Centril · 2019-02-22T16:52:41Z

@bors r+ p=9

bors · 2019-02-22T16:52:42Z

📌 Commit fda51c2 has been approved by Centril

Cherry-picked (and squashed) from rust-lang#58227.

@pietroalbini

Beta rollups - #58649 - #58592 - #58574 - #58227 - #58056 - #57859 - #57710 A few of these are via #58641. r? @pietroalbini

Centril · 2019-02-23T01:16:38Z

@bors p=0

Will include in a rollup.

@Mark-Simulacrum

Updated RELEASES.md for 1.33.0 [Rendered](https://github.com/Aaronepower/rust/blob/master/RELEASES.md) r? @Mark-Simulacrum cc @rust-lang/release

@Mark-Simulacrum

Updated RELEASES.md for 1.33.0 [Rendered](https://github.com/Aaronepower/rust/blob/master/RELEASES.md) r? @Mark-Simulacrum cc @rust-lang/release

@Mark-Simulacrum

Updated RELEASES.md for 1.33.0 [Rendered](https://github.com/Aaronepower/rust/blob/master/RELEASES.md) r? @Mark-Simulacrum cc @rust-lang/release

@Mark-Simulacrum

Updated RELEASES.md for 1.33.0 [Rendered](https://github.com/Aaronepower/rust/blob/master/RELEASES.md) r? @Mark-Simulacrum cc @rust-lang/release

@ghost

Rollup of 16 pull requests Successful merges: - #58100 (Transition librustdoc to Rust 2018) - #58122 (RangeInclusive internal iteration performance improvement.) - #58199 (Add better error message for partial move) - #58227 (Updated RELEASES.md for 1.33.0) - #58353 (Check the Self-type of inherent associated constants) - #58453 (SGX target: fix panic = abort) - #58476 (Remove `LazyTokenStream`.) - #58526 (Special suggestion for illegal unicode curly quote pairs) - #58595 (Turn duration consts into associated consts) - #58609 (Allow Self::Module to be mutated.) - #58628 (Optimise vec![false; N] to zero-alloc) - #58643 (Don't generate minification variables if minification disabled) - #58648 (Update tests to account for cross-platform testing and miri.) - #58654 (Do not underflow after resetting unmatched braces count) - #58658 (Add expected/provided byte alignments to validation error message) - #58667 (Reduce Miri-related Code Repetition `like (n << amt) >> amt`) Failed merges: r? @ghost

jethrogb · 2019-02-26T00:38:06Z

RELEASES.md

+Language
+--------
+- [You can now use the `cfg(target_vendor)` attribute.][57465] E.g.
+  `#[cfg(target_vendor="linux")] fn main() { println!("Hello Linux!"); }`


I don't think this example makes sense. Maybe use one of the vendors shown in the reference?

cc @Mark-Simulacrum -- presumably we don't want to change this now because we already promoted beta=>stable... but we could merge it into nightly for posterity?

PRs are welcome!

niklasad1 · 2019-02-26T09:29:58Z

RELEASES.md

+
+Compatibility Notes
+-------------------
+- The methods `str::{trim_left, trim_right, trim_left_matches, trim_right_matches}`


Well, I think it is also worth mentioning #[rustc_deprecated(since = "1.33.0", reason = "replaced by Error::source, which can support downcasting

Updated RELEASES.md for 1.33.0

50be479

rust-highfive assigned Mark-Simulacrum Feb 6, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 6, 2019

Mark-Simulacrum reviewed Feb 6, 2019

View reviewed changes

RELEASES.md Outdated Show resolved Hide resolved

jonas-schievink reviewed Feb 6, 2019

View reviewed changes

RELEASES.md Outdated Show resolved Hide resolved

RELEASES.md Outdated Show resolved Hide resolved

RELEASES.md Show resolved Hide resolved

RELEASES.md Outdated Show resolved Hide resolved

Update RELEASES.md

6c71e7d

mark-i-m reviewed Feb 7, 2019

View reviewed changes

RELEASES.md Outdated Show resolved Hide resolved

nikic reviewed Feb 7, 2019

View reviewed changes

RELEASES.md Outdated Show resolved Hide resolved

kennytm added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Feb 8, 2019

pietroalbini added beta-accepted Accepted for backporting to the compiler in the beta channel. T-release Relevant to the release subteam, which will review and decide on the PR/issue. labels Feb 8, 2019

tspiteri reviewed Feb 8, 2019

View reviewed changes

RELEASES.md Outdated Show resolved Hide resolved

Update RELEASES.md

fb3ae57

Co-Authored-By: Aaronepower <Aaronepower@users.noreply.github.com>

Centril reviewed Feb 11, 2019

View reviewed changes

Centril and others added 4 commits February 12, 2019 10:40

Update RELEASES.md

73921f6

Co-Authored-By: Aaronepower <Aaronepower@users.noreply.github.com>

Update RELEASES.md

8a026f1

Co-Authored-By: Aaronepower <Aaronepower@users.noreply.github.com>

Update RELEASES.md

4c0a3d5

Co-Authored-By: Aaronepower <Aaronepower@users.noreply.github.com>

Update RELEASES.md

ee3371e

Co-Authored-By: Aaronepower <Aaronepower@users.noreply.github.com>

Centril reviewed Feb 12, 2019

View reviewed changes

RELEASES.md Outdated Show resolved Hide resolved

Update RELEASES.md

a496450

Co-Authored-By: Aaronepower <Aaronepower@users.noreply.github.com>

Aaronepower added 2 commits February 20, 2019 15:51

Update RELEASES.md

2621564

Update RELEASES.md

d072510

tspiteri reviewed Feb 20, 2019

View reviewed changes

RELEASES.md Outdated Show resolved Hide resolved

Update RELEASES.md

42d749c

Co-Authored-By: Aaronepower <Aaronepower@users.noreply.github.com>

Centril reviewed Feb 20, 2019

View reviewed changes

RELEASES.md Outdated Show resolved Hide resolved

Update RELEASES.md

8060eb4

Aaronepower and others added 2 commits February 21, 2019 14:10

Update RELEASES.md

0ab2aed

Update RELEASES.md

fda51c2

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 22, 2019

Centril mentioned this pull request Feb 22, 2019

[BETA] Universe leak check #58641

Closed

Mark-Simulacrum mentioned this pull request Feb 22, 2019

Beta rollups #58656

Merged

pietroalbini removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Feb 22, 2019

nikomatsakis pushed a commit to Mark-Simulacrum/rust that referenced this pull request Feb 22, 2019

Updated RELEASES.md for 1.33.0

fdd5467

Cherry-picked (and squashed) from rust-lang#58227.

bors added a commit that referenced this pull request Feb 23, 2019

Auto merge of #58656 - Mark-Simulacrum:beta-rollups, r=pietroalbini

bb2d0ea

Beta rollups - #58649 - #58592 - #58574 - #58227 - #58056 - #57859 - #57710 A few of these are via #58641. r? @pietroalbini

Centril mentioned this pull request Feb 23, 2019

Rollup of 16 pull requests #58665

Closed

Centril mentioned this pull request Feb 23, 2019

Rollup of 15 pull requests #58666

Closed

Centril mentioned this pull request Feb 23, 2019

Rollup of 16 pull requests #58668

Closed

Centril mentioned this pull request Feb 23, 2019

Rollup of 16 pull requests #58669

Merged

bors merged commit fda51c2 into rust-lang:master Feb 23, 2019

jethrogb reviewed Feb 26, 2019

View reviewed changes

niklasad1 reviewed Feb 26, 2019

View reviewed changes

Centril mentioned this pull request Feb 28, 2019

Update RELEASES to include missing feature #58790

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updated RELEASES.md for 1.33.0 #58227

Updated RELEASES.md for 1.33.0 #58227

XAMPPRocky commented Feb 6, 2019

imp commented Feb 12, 2019

tesuji commented Feb 12, 2019

Centril commented Feb 12, 2019 •

edited

Loading

XAMPPRocky commented Feb 13, 2019

Centril commented Feb 22, 2019

bors commented Feb 22, 2019

Centril commented Feb 23, 2019

jethrogb Feb 26, 2019

Centril Feb 26, 2019

Mark-Simulacrum Feb 26, 2019

niklasad1 Feb 26, 2019 •

edited

Loading

Updated RELEASES.md for 1.33.0 #58227

Updated RELEASES.md for 1.33.0 #58227

Conversation

XAMPPRocky commented Feb 6, 2019

imp commented Feb 12, 2019

tesuji commented Feb 12, 2019

Centril commented Feb 12, 2019 • edited Loading

XAMPPRocky commented Feb 13, 2019

Centril commented Feb 22, 2019

bors commented Feb 22, 2019

Centril commented Feb 23, 2019

jethrogb Feb 26, 2019

Choose a reason for hiding this comment

Centril Feb 26, 2019

Choose a reason for hiding this comment

Mark-Simulacrum Feb 26, 2019

Choose a reason for hiding this comment

niklasad1 Feb 26, 2019 • edited Loading

Choose a reason for hiding this comment

Centril commented Feb 12, 2019 •

edited

Loading

niklasad1 Feb 26, 2019 •

edited

Loading