Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[beta] Fix setting PATH during linkage on windows-gnu #42567

Merged
merged 1 commit into from
Jun 13, 2017

Conversation

CryZe
Copy link
Contributor

@CryZe CryZe commented Jun 9, 2017

Beta backport of #42481

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Collaborator

warning Warning warning

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@nikomatsakis
Copy link
Contributor

r? @brson -- looks straightforward enough

@rust-highfive rust-highfive assigned brson and unassigned nikomatsakis Jun 9, 2017
@Mark-Simulacrum Mark-Simulacrum added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 11, 2017
@alexcrichton
Copy link
Member

@bors: r+

Thanks @CryZe!

@bors
Copy link
Contributor

bors commented Jun 12, 2017

📌 Commit 87d5c72 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Jun 12, 2017

⌛ Testing commit 87d5c72 with merge 0cd6b0d...

bors added a commit that referenced this pull request Jun 12, 2017
[beta] Fix setting PATH during linkage on windows-gnu

Beta backport of #42481
@bors
Copy link
Contributor

bors commented Jun 13, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 0cd6b0d to beta...

@bors bors merged commit 87d5c72 into rust-lang:beta Jun 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants