Fix setting PATH during linkage on windows-gnu #42481
Conversation
brson
added
the
beta-nominated
|
Oh actually I miststated - this is not like previously, now this is only frobbing PATH at all for linker invocation on windows, whereas before it was doing it on all platforms. Again we think it only matters on windows. |
src/librustc_trans/back/link.rs
Outdated
| // On windows-gnu (msvc is handled separately), we bundle | ||
| // gcc and other tools with the official releases. This is | ||
| // how the other tools that gcc itself needs are located. | ||
| vec![("PATH".into(), command_path(sess, linker.map(PathBuf::from)))] |
There was a problem hiding this comment.
This doesn't seem right. The second parameter to command_path is added to the end of %Path% and before #42225 it was only used by MSVC.
There was a problem hiding this comment.
Ah yes. I suspected that path had no effect. I'll update.
|
Ok, now the patch is written so that all non-msvc platforms set up the PATH during linking as previously. The |
alexcrichton
added
the
beta-accepted
|
@bors: r+ |
|
📌 Commit e8689c7 has been approved by |
aidanhs
added
the
S-waiting-on-bors
Fix setting PATH during linkage on windows-gnu This makes the behavior almost exactly the same as before the VS2017 patch, except that on MSVC builds the host bin path is no longer added to PATH. I am not sure that's actually necessary on any platform. r? @alexcrichton Fixes #42422
|
☀️ Test successful - status-appveyor, status-travis |
alexcrichton
removed
the
beta-nominated
[beta] Fix setting PATH during linkage on windows-gnu Beta backport of #42481
This makes the behavior almost exactly the same as before the VS2017 patch, except that on MSVC builds the host bin path is no longer added to PATH. I am not sure that's actually necessary on any platform.
r? @alexcrichton
Fixes #42422