doc: concat_idents! macro: more on its limitations. #31542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
| /// capture local variables, and macros are only allowed in item, | ||
| /// statement or expression position, meaning this macro may be difficult to | ||
| /// use in some situations. | ||
| /// capture local variables. Also, as a general rule, macros are only |
There was a problem hiding this comment.
one space after a period please!
|
Your English is great! Just a small nit about the spaces and let's |
Signed-off-by: NODA, Kai <nodakai@gmail.com>
nodakai
force-pushed
the
concat_idents-desc
branch
from
40ad3e5
to
cec158b
Compare
|
Thanks, corrected to a single space style. |
|
@bors: r+ rollup On Feb 10, 2016, 15:26 -0500, Kai Nodanotifications@github.com, wrote:
|
|
📌 Commit cec158b has been approved by |
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
Feb 13, 2016
…klabnik Just a small documentation change. It would be great if anyone could check my English.
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Feb 13, 2016
…klabnik Just a small documentation change. It would be great if anyone could check my English.
bors
added a commit
that referenced
this pull request
Feb 13, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a small documentation change.
It would be great if anyone could check my English.