Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

std: Reexport std::net::tcp::Incoming #25522

Merged
merged 1 commit into from
May 17, 2015
Merged

std: Reexport std::net::tcp::Incoming #25522

merged 1 commit into from
May 17, 2015

Conversation

alexcrichton
Copy link
Member

This iterator was mistakenly not reexported at the top level, preventing
actually naming the type!

Closes #25519

@alexcrichton
std: Reexport std::net::tcp::Incoming
e5e722b 
This iterator was mistakenly not reexported at the top level, preventing
actually naming the type!

Closes rust-lang#25519
@alexcrichton alexcrichton added the beta-nominated Nominated for backporting to the compiler in the beta channel. label May 17, 2015
@alexcrichton
Copy link
Member Author

r? @aturon

@rust-highfive rust-highfive assigned aturon and unassigned brson May 17, 2015
@rust-highfive
Copy link
Collaborator

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@sfackler
Copy link
Member

@bors r+ e5e722b rollup

Why didn't this hit the private-types-in-public-APIs check?

Manishearth added a commit to Manishearth/rust that referenced this pull request May 17, 2015
@Manishearth
Rollup merge of rust-lang#25522 - alexcrichton:reexport-incoming, r=s…
a0815c8 
…fackler

This iterator was mistakenly not reexported at the top level, preventing
actually naming the type!

Closes rust-lang#25519
@Manishearth Manishearth mentioned this pull request May 17, 2015
Merged
bors added a commit that referenced this pull request May 17, 2015
@bors
Auto merge of #25525 - Manishearth:rollup, r=Manishearth
9f3a7f0 
- Successful merges: #25465, #25469, #25472, #25474, #25476, #25484, #25490, #25493, #25503, #25506, #25508, #25510, #25516, #25522
- Failed merges:
@bors bors merged commit e5e722b into rust-lang:master May 17, 2015
@alexcrichton alexcrichton deleted the reexport-incoming branch May 19, 2015 05:56
@alexcrichton alexcrichton added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label May 28, 2015
@alexcrichton
Copy link
Member Author

triage: beta-accepted

@alexcrichton alexcrichton added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Jun 9, 2015
@alexcrichton alexcrichton mentioned this pull request Jun 10, 2015
Merged
@alexcrichton alexcrichton removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jun 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aturon aturon

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TcpListener::incoming return value isn't linked
6 participants
@alexcrichton @rust-highfive @sfackler @brson @aturon @bors