Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the shown installed rust version to 1.0 #25493

Merged
merged 2 commits into from
May 17, 2015

Conversation

coffeejunk
Copy link
Contributor

Rust is out of beta 🎉

r? @steveklabnik

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@Stebalien
Copy link
Contributor

Could you fix the links as well (see #25489)?

@coffeejunk
Copy link
Contributor Author

Done @Stebalien

@alexcrichton
Copy link
Member

@bors: r+ e095e39 rollup

Thanks!

Manishearth added a commit to Manishearth/rust that referenced this pull request May 17, 2015
…rsion, r=alexcrichton

Rust is out of beta 🎉 

r? @steveklabnik
bors added a commit that referenced this pull request May 17, 2015
@bors bors merged commit e095e39 into rust-lang:master May 17, 2015
@Stebalien
Copy link
Contributor

@alexcrichton Could you backport this to the 1.0 book?

@steveklabnik
Copy link
Member

We do not do doc backports.

@coffeejunk coffeejunk deleted the update_installed_rust_version branch May 20, 2015 15:15
@Stebalien
Copy link
Contributor

@steveklabnik Why not? The link in the doc is wrong and this is the second person to download the wrong rust.

@steveklabnik
Copy link
Member

There will always be things wrong in every release. You could also make the case that a new bug that gets fixed on master should be backported, because rustc does something wrong.

So, given that no software is perfect, you have to ask 'what's the criteria for backporting'? And, given that we already release new y (as in x.y.z) versions of the compiler every six weeks, z versions are basically only going to be released for security or soundness reasons. So that's why things won't be backported to 1.0.

You could make an argument about backporting to 1.1, but we've decided generally to be very conservative with the stable branch. That's part of it being stable. I may end up doing a few particularly egregious fixes, like the table formatting in the stack and the heap, if that didn't make it in before beta, but that's only for 1.1: in general, after that, we won't be doing any doc backporting generally.

@Stebalien
Copy link
Contributor

Fair enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants