Emit better suggestions for `&T == T` and `T == &T` #118431

sjwang05 · 2023-11-29T02:56:41Z

rustbot · 2023-11-29T02:56:50Z

(rustbot has picked a reviewer for you, use r? to override)

rustbot · 2023-11-29T02:56:53Z

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

rustbot · 2023-11-29T03:02:35Z

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

compiler/rustc_trait_selection/Cargo.toml

compiler/rustc_hir_typeck/src/op.rs

sjwang05 · 2023-11-30T06:15:51Z

Fixed the ICE by checking for empty spans before emitting the suggestion--looks like debug assertions were required to reproduce it.

@rustbot review

cjgillot · 2023-12-03T15:16:06Z

@estebank do you mind taking this review?

compiler/rustc_trait_selection/src/traits/error_reporting/suggestions.rs

estebank · 2023-12-05T00:35:54Z

r? @estebank

bors · 2023-12-13T13:20:30Z

☔ The latest upstream changes (presumably #118500) made this pull request unmergeable. Please resolve the merge conflicts.

estebank · 2023-12-26T20:08:32Z

tests/ui/binop/binary-op-suggest-deref.stderr

+help: consider annotating `Foo` with `#[derive(PartialEq)]`
+   |
+LL +     #[derive(PartialEq)]
+LL |     struct Foo;
+   |


We should filter this suggestion to only show up in the case where both arms are (after peel_refs()) Foo.

Addressed at #119362

estebank · 2023-12-26T20:15:26Z

@bors r+

bors · 2023-12-26T20:15:30Z

📌 Commit 2618e0f has been approved by estebank

It is now in the queue for this repository.

bors · 2023-12-26T21:34:28Z

⌛ Testing commit 2618e0f with merge 2df6406...

bors · 2023-12-26T23:30:28Z

☀️ Test successful - checks-actions
Approved by: estebank
Pushing 2df6406 to master...

rust-timer · 2023-12-27T04:29:57Z

Finished benchmarking commit (2df6406): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Warning ⚠: The following benchmark(s) failed to build:

stm32f4-0.14.0

cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	24.0%	[18.1%, 29.5%]	3
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	24.0%	[18.1%, 29.5%]	3

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.9%	[2.9%, 2.9%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.7%	[-2.7%, -2.7%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.1%	[-2.7%, 2.9%]	2

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	18.5%	[15.5%, 23.7%]	3
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	18.5%	[15.5%, 23.7%]	3

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 670.702s -> 669.634s (-0.16%)
Artifact size: 312.43 MiB -> 312.43 MiB (0.00%)

lqd · 2023-12-27T07:58:36Z

Most likely the slow S3 uploads issue on the collector, not a real perf regression.

estebank · 2023-12-27T16:58:21Z

@lqd thank goodness, I almost had a heart attack. I see a corresponding "improvement" in #119328 (comment)

Kobzol · 2023-12-27T17:57:51Z

Probably caused by slow S3 uploads.

@rustbot label: +perf-regression-triaged

compiler-errors · 2023-12-27T21:18:42Z

compiler/rustc_middle/src/traits/mod.rs

+        let mut base_trait_pred = None;
+        while let Some((parent_code, parent_pred)) = base_cause.parent() {
+            base_cause = parent_code;
+            if let Some(parent_pred) = parent_pred {


This will return predicates that don't actually line up with the derived cause if parent_pred is None. This is partly why #119352 is failing.

#119361 (review)

rustbot assigned cjgillot Nov 29, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 29, 2023

sjwang05 force-pushed the issue-44695 branch from 4275e80 to 6f25d87 Compare November 29, 2023 03:02

This comment has been minimized.

Sign in to view

compiler-errors reviewed Nov 29, 2023

View reviewed changes

compiler/rustc_trait_selection/Cargo.toml Outdated Show resolved Hide resolved

estebank reviewed Nov 29, 2023

View reviewed changes

compiler/rustc_hir_typeck/src/op.rs Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

This comment was marked as outdated.

Sign in to view

This comment has been minimized.

Sign in to view

This comment was marked as outdated.

Sign in to view

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 30, 2023

sjwang05 force-pushed the issue-44695 branch from 89080c1 to 32d7890 Compare November 30, 2023 05:34

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 30, 2023

ghost reviewed Dec 3, 2023

View reviewed changes

compiler/rustc_trait_selection/src/traits/error_reporting/suggestions.rs Outdated Show resolved Hide resolved

sjwang05 force-pushed the issue-44695 branch from b259a38 to 1091774 Compare December 3, 2023 21:49

rustbot assigned estebank and unassigned cjgillot Dec 5, 2023

sjwang05 force-pushed the issue-44695 branch from 1091774 to 21ea886 Compare December 15, 2023 02:19

This comment has been minimized.

Sign in to view

sjwang05 force-pushed the issue-44695 branch from 21ea886 to 2b88d14 Compare December 15, 2023 02:46

Provide better suggestions for T == &T and &T == T

2618e0f

sjwang05 force-pushed the issue-44695 branch from 2b88d14 to 2618e0f Compare December 17, 2023 04:05

estebank reviewed Dec 26, 2023

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 26, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 26, 2023

bors merged commit 2df6406 into rust-lang:master Dec 26, 2023
12 checks passed

rustbot added this to the 1.77.0 milestone Dec 26, 2023

rustbot added the perf-regression Performance regression. label Dec 27, 2023

Kobzol mentioned this pull request Dec 27, 2023

Do not store results of self-profile benchmark runs into the DB rust-lang/rustc-perf#1789

Closed

estebank mentioned this pull request Dec 27, 2023

Suggest = to == in more cases, even in the face of reference mismatch #119328

Merged

matthiaskrgr mentioned this pull request Dec 27, 2023

ICE: range start index 2 out of range for slice of length 1 #119352

Closed

rustbot added the perf-regression-triaged The performance regression has been triaged. label Dec 27, 2023

compiler-errors reviewed Dec 27, 2023

View reviewed changes

darklyspaced mentioned this pull request Dec 30, 2023

range start index 2 out of range for slice of length 1 #119435

Closed

sjwang05 deleted the issue-44695 branch January 16, 2024 03:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Emit better suggestions for `&T == T` and `T == &T` #118431

Emit better suggestions for `&T == T` and `T == &T` #118431

sjwang05 commented Nov 29, 2023

rustbot commented Nov 29, 2023

rustbot commented Nov 29, 2023

rustbot commented Nov 29, 2023

This comment has been minimized.

This comment has been minimized.

This comment was marked as outdated.

This comment has been minimized.

This comment has been minimized.

This comment was marked as outdated.

sjwang05 commented Nov 30, 2023

cjgillot commented Dec 3, 2023

estebank commented Dec 5, 2023

bors commented Dec 13, 2023

This comment has been minimized.

estebank Dec 26, 2023 •

edited

Loading

estebank Dec 27, 2023 •

edited

Loading

estebank commented Dec 26, 2023

bors commented Dec 26, 2023

bors commented Dec 26, 2023

bors commented Dec 26, 2023

rust-timer commented Dec 27, 2023

lqd commented Dec 27, 2023

estebank commented Dec 27, 2023 •

edited

Loading

Kobzol commented Dec 27, 2023

compiler-errors Dec 27, 2023

compiler-errors Dec 27, 2023

Emit better suggestions for &T == T and T == &T #118431

Emit better suggestions for &T == T and T == &T #118431

Conversation

sjwang05 commented Nov 29, 2023

rustbot commented Nov 29, 2023

rustbot commented Nov 29, 2023

rustbot commented Nov 29, 2023

This comment has been minimized.

This comment has been minimized.

This comment was marked as outdated.

This comment has been minimized.

This comment has been minimized.

This comment was marked as outdated.

sjwang05 commented Nov 30, 2023

cjgillot commented Dec 3, 2023

estebank commented Dec 5, 2023

bors commented Dec 13, 2023

This comment has been minimized.

estebank Dec 26, 2023 • edited Loading

Choose a reason for hiding this comment

estebank Dec 27, 2023 • edited Loading

Choose a reason for hiding this comment

estebank commented Dec 26, 2023

bors commented Dec 26, 2023

bors commented Dec 26, 2023

bors commented Dec 26, 2023

rust-timer commented Dec 27, 2023

Overall result: ❌ regressions - ACTION NEEDED

Instruction count

Max RSS (memory usage)

Cycles

Binary size

lqd commented Dec 27, 2023

estebank commented Dec 27, 2023 • edited Loading

Kobzol commented Dec 27, 2023

compiler-errors Dec 27, 2023

Choose a reason for hiding this comment

compiler-errors Dec 27, 2023

Choose a reason for hiding this comment

Emit better suggestions for `&T == T` and `T == &T` #118431

Emit better suggestions for `&T == T` and `T == &T` #118431

estebank Dec 26, 2023 •

edited

Loading

estebank Dec 27, 2023 •

edited

Loading

estebank commented Dec 27, 2023 •

edited

Loading