Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not store results of self-profile benchmark runs into the DB #1789

Closed
Kobzol opened this issue Dec 27, 2023 · 0 comments · Fixed by #1790
Closed

Do not store results of self-profile benchmark runs into the DB #1789

Kobzol opened this issue Dec 27, 2023 · 0 comments · Fixed by #1790
Assignees

Comments

@Kobzol
Copy link
Contributor

Kobzol commented Dec 27, 2023

Currently, if you request --self-profile gathering in the collector, it will gather self profiles for the first iteration of a single benchmark, and then ignore the flag for any further iterations. It now stores gathered metrics (e.g. instruction count) into the DB for the first iteration, which is not a good idea - these values are 20-30% higher than the baseline (because self-profile is enabled), and they needlessly occupy space in the DB, and can cause weird results like this.

We should just ignore the gathered metrics for the first iteration of the benchmark run if self profile gathering is enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant