Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 7 pull requests #111452

Merged
merged 15 commits into from
May 11, 2023
Merged

Rollup of 7 pull requests #111452

merged 15 commits into from
May 11, 2023

Conversation

matthiaskrgr
Copy link
Member

Successful merges:

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

clubby789 and others added 15 commits April 30, 2023 19:17
The regions don't need to be mutable because we pass a copy of them to LLVM
instead, and this matches the `*const` in the Rust-side signature.
For some reason, the called function is `cleanup` on LLVM 17 instead of
`filter`.

r? @Amanieu
…rrow, r=cjgillot

Prevent ICE with broken borrow in closure

r? `@Nilstrieb`
Fixes rust-lang#108683

This solution isn't ideal, I'm hoping to find a way to continue compilation without ICEing.
…trochenkov

Fix mishandled `--check-cfg` arguments order

This PR fixes a bug in `--check-cfg` where the order of `--check-cfg=names(a)` and `--check-cfg=values(a,…)` would trip the compiler.

Fixes rust-lang#111291
cc `@taiki-e` `@petrochenkov`
Isolate coverage FFI type layouts from their underlying LLVM C++ types

I noticed that several of the types used to send coverage information through FFI are not properly isolated from the layout of their corresponding C++ types in the LLVM API.

This PR adds more explicitly-defined FFI struct/enum types in `CoverageMappingWrapper.cpp`, so that Rust source files in `rustc_codegen_ssa` and `rustc_codegen_llvm` aren't directly exposed to LLVM C++ types.
vec-shrink-panik: update expectations to work on LLVM 17

For some reason, the called function is `cleanup` on LLVM 17 instead of `filter`.

r? `@Amanieu`
…=jyn514

Add esp-idf platform-support page

As mentioned in rust-lang#111369 (comment), the initial PR for esp-idf didn't include a platform support document which is required for the merge of  rust-lang#111369.
Use visit_assign to detect SSA locals.

I screwed up the logic in 3c43b61.

Fixes rust-lang#111426
…, r=notriddle

Use proper impl self type for alias impl in rustdoc

We don't want to use `type_of(type_alias)`, we want to use `type_of(impl)` -- this will give us the self type of the impl *properly substituted* in the case that it's an alias.

Fixes rust-lang#111420
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels May 11, 2023
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=57

@bors
Copy link
Contributor

bors commented May 11, 2023

📌 Commit 07af55e has been approved by matthiaskrgr

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented May 11, 2023

🌲 The tree is currently closed for pull requests below priority 50. This pull request will be tested once the tree is reopened.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 11, 2023
@bors
Copy link
Contributor

bors commented May 11, 2023

⌛ Testing commit 07af55e with merge 4d941cd...

@bors
Copy link
Contributor

bors commented May 11, 2023

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 4d941cd to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 11, 2023
@bors bors merged commit 4d941cd into rust-lang:master May 11, 2023
@rustbot rustbot added this to the 1.71.0 milestone May 11, 2023
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Perf Build Sha
#111448 e869eea4cc2abb8d62892fe413f5bc170fa663d2
#111432 03c6614968f27e5c904fe6266431b182dd3359e4
#111389 a11be896adc66a53838ff763c37f3b5083857150
#111385 d497a0fcd5b5ad2caf5d243429f400e34504a2ba
#111382 129b364fb3a04ad769c7a0c9259e16d8ecb0303e
#111292 855fcce6fdc816278c4fb92c10b9fb1ff6c7d83d
#108705 9d047cb02331e941a225ca137ba80c680f0782b2

previous master: 9a767b6b9e

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (4d941cd): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
4.5% [4.5%, 4.5%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.3% [-2.4%, -2.2%] 2
All ❌✅ (primary) 4.5% [4.5%, 4.5%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 659.961s -> 660.266s (0.05%)

@matthiaskrgr matthiaskrgr deleted the rollup-uic8dgy branch March 16, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.