Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add esp-idf platform-support page #111389

Merged
merged 1 commit into from
May 11, 2023
Merged

Add esp-idf platform-support page #111389

merged 1 commit into from
May 11, 2023

Conversation

MabezDev
Copy link
Contributor

@MabezDev MabezDev commented May 9, 2023

As mentioned in #111369 (comment), the initial PR for esp-idf didn't include a platform support document which is required for the merge of #111369.

@rustbot
Copy link
Collaborator

rustbot commented May 9, 2023

r? @JohnTitor

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 9, 2023
@MabezDev
Copy link
Contributor Author

MabezDev commented May 9, 2023

r? @Urgau

@rustbot
Copy link
Collaborator

rustbot commented May 9, 2023

Failed to set assignee to Urgau: invalid assignee

Note: Only org members, users with write permissions, or people who have commented on the PR may be assigned.

@MabezDev MabezDev mentioned this pull request May 9, 2023
Merged
Urgau
Urgau requested changes May 9, 2023
View reviewed changes
Copy link
Member

@Urgau Urgau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly what I hoped. But you are missing the link in src/doc/rustc/src/platform-support.md:

- [riscv32imc-esp-espidf` | ✓ |  | RISC-V ESP-IDF
+ [`riscv32imc-esp-espidf`](platform-support/esp-idf.md) | ✓ |  | RISC-V ESP-IDF

src/doc/rustc/src/platform-support/esp-idf.md Outdated Show resolved Hide resolved
src/doc/rustc/src/platform-support/esp-idf.md Outdated Show resolved Hide resolved
src/doc/rustc/src/platform-support/esp-idf.md Outdated Show resolved Hide resolved
@MabezDev MabezDev force-pushed the esp-idf-platform-support branch 3 times, most recently from 5599601 to 8622048 Compare May 9, 2023 13:11
@MabezDev MabezDev requested a review from Urgau May 9, 2023 13:11
Urgau
Urgau reviewed May 9, 2023
View reviewed changes
src/doc/rustc/src/platform-support.md Outdated Show resolved Hide resolved
src/doc/rustc/src/platform-support.md Outdated Show resolved Hide resolved
@MabezDev MabezDev force-pushed the esp-idf-platform-support branch 2 times, most recently from 0b9c54d to fb1261f Compare May 9, 2023 13:21
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Urgau
Copy link
Member

Urgau commented May 9, 2023

The job x86_64-gnu-llvm-14 failed! Check out the build log: (web) (plain)
Click to see the possible cause of the failure (guessed by this bot)

Forgot to mention that the page also needs to be added to the TOC, example here: https://github.com/rust-lang/rust/pull/108792/files#diff-4217453d9bcaffc80a2492af62d73ab817d553e3668fc1228cecfd60014e1d32

Urgau
Urgau reviewed May 9, 2023
View reviewed changes
src/doc/rustc/src/SUMMARY.md Outdated Show resolved Hide resolved
Urgau
Urgau approved these changes May 9, 2023
View reviewed changes
Copy link
Member

@Urgau Urgau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me 👍 (although I don't have review rights so will need another review)

@GuillaumeGomez
Copy link
Member

I'll set someone else I think can help here.

r? @Amanieu

@rustbot rustbot assigned Amanieu and unassigned JohnTitor May 9, 2023
@Nassiel
Copy link
Contributor

Nassiel commented May 9, 2023

Exactly what I hoped. But you are missing the link in src/doc/rustc/src/platform-support.md:

- [riscv32imc-esp-espidf` | ✓ |  | RISC-V ESP-IDF
+ [`riscv32imc-esp-espidf`](platform-support/esp-idf.md) | ✓ |  | RISC-V ESP-IDF

@MabezDev I'll include this on the other PR

@jyn514
Copy link
Member

jyn514 commented May 10, 2023

This looks great, thanks!

@bors r+

@bors
Copy link
Contributor

bors commented May 10, 2023

📌 Commit 53e49f4 has been approved by jyn514

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented May 10, 2023

🌲 The tree is currently closed for pull requests below priority 50. This pull request will be tested once the tree is reopened.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 10, 2023
@jyn514
Copy link
Member

jyn514 commented May 10, 2023

@bors rollup

@matthiaskrgr matthiaskrgr mentioned this pull request May 11, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 11, 2023
@bors
Auto merge of rust-lang#111452 - matthiaskrgr:rollup-uic8dgy, r=matth…
4d941cd 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#108705 (Prevent ICE with broken borrow in closure)
 - rust-lang#111292 (Fix mishandled `--check-cfg` arguments order)
 - rust-lang#111382 (Isolate coverage FFI type layouts from their underlying LLVM C++ types)
 - rust-lang#111385 (vec-shrink-panik: update expectations to work on LLVM 17)
 - rust-lang#111389 (Add esp-idf platform-support page)
 - rust-lang#111432 (Use visit_assign to detect SSA locals.)
 - rust-lang#111448 (Use proper impl self type for alias impl in rustdoc)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 3b7c02b into rust-lang:master May 11, 2023
@rustbot rustbot added this to the 1.71.0 milestone May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Urgau Urgau Urgau approved these changes

Assignees

@Amanieu Amanieu

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.71.0
Development

Successfully merging this pull request may close these issues.
10 participants
@MabezDev @rustbot @rust-log-analyzer @Urgau @GuillaumeGomez @Nassiel @jyn514 @bors @Amanieu @JohnTitor