x fmt: Only check modified files locally #108773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, `x fmt` would only format modified files, while `x fmt .` and `x fmt --check` would still look at all files. After this change, `x fmt --check` only looks at modified files locally. I feel pretty confident in this change - other than rust-lang#106261, no one has reported bugs in `get_modified_rs_files` since it was added in rust-lang#105702.
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
Looks great! Thanks for the PR! |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 6, 2023
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#108244 (Add test for semicolon recovery ICE) - rust-lang#108746 (Don't project to RPITIT that has no default value) - rust-lang#108764 (Tweaks to -Zdrop-tracking-mir) - rust-lang#108770 (Improve documentation and argument naming of some TyCtxt methods) - rust-lang#108773 (x fmt: Only check modified files locally) - rust-lang#108775 (Use the correct bound vars in return type suggestion.) - rust-lang#108776 (Make `x test tidy` less noisy) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
x fmtwould only format modified files, whilex fmt .andx fmt --checkwould still look at all files. After this change,x fmt --checkonly looks at modified files locally.I feel pretty confident in this change - other than #106261, no one has reported bugs in
get_modified_rs_filessince it was added in #105702.Combined with the changes in #108772, this brings the time for me to run
x t tidywith a hot FS cache down from 5 to 2 seconds (and moves the majority of the time spent back totidy check, which means it can be sped up more in the future).