Tweaks to -Zdrop-tracking-mir #108764
Merged
Tweaks to -Zdrop-tracking-mir #108764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @davidtwco (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
| @@ -149,6 +149,6 @@ impl<'tcx> TraitEngine<'tcx> for FulfillmentCtxt<'tcx> { | |||
| &mut self, | |||
| _: &InferCtxt<'tcx>, | |||
| ) -> Vec<PredicateObligation<'tcx>> { | |||
| unimplemented!() | |||
| std::mem::take(&mut self.obligations) | |||
There was a problem hiding this comment.
Just noting that this won't do much, since these are always going to be root obligations. But yeah, no need to panic here.
compiler-errors
approved these changes
Mar 5, 2023
|
r? @compiler-errors @bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 6, 2023
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#108244 (Add test for semicolon recovery ICE) - rust-lang#108746 (Don't project to RPITIT that has no default value) - rust-lang#108764 (Tweaks to -Zdrop-tracking-mir) - rust-lang#108770 (Improve documentation and argument naming of some TyCtxt methods) - rust-lang#108773 (x fmt: Only check modified files locally) - rust-lang#108775 (Use the correct bound vars in return type suggestion.) - rust-lang#108776 (Make `x test tidy` less noisy) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split from #107421
3 commits: 1 diagnostic improvement and 2 ICEs.