bootstrap: Get rid of tail_args in stream_cargo #106305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, clean only supported `--stage 0` for specific crates.
The new `crate_description` function generates a string that looks
like
```
: {rustc_query_impl}
```
Before:
```
Testing ["rustc_interface"] stage0 (aarch64-unknown-linux-gnu -> aarch64-unknown-linux-gnu)
```
After:
```
Testing {rustc_interface} stage0 (aarch64-unknown-linux-gnu -> aarch64-unknown-linux-gnu)
```
Note there is a slight consistency between `build` and `test`: The
former doesn't print "compiler artifacts". It would be annoying to fix
and doesn't hurt anything, so I left it be.
```
; x t rustc_interface --stage 0 --dry-run
Testing {rustc_interface} stage0 (aarch64-unknown-linux-gnu -> aarch64-unknown-linux-gnu)
; x b rustc_interface --stage 0 --dry-run
Building {rustc_interface} stage0 compiler artifacts (aarch64-unknown-linux-gnu -> aarch64-unknown-linux-gnu)
```
rustbot
added
T-bootstrap
rust-cloud-vms
bot
force-pushed
the
tail-args
branch
from
7b778be
to
9dfe504
Compare
|
r=me |
bors
added
S-waiting-on-bors
jyn514
added a commit
to jyn514/rust
that referenced
this pull request
Dec 30, 2022
bootstrap: Get rid of tail_args in stream_cargo Based on rust-lang#106303 for convenience. r? `@Mark-Simulacrum`
jyn514
added a commit
to jyn514/rust
that referenced
this pull request
Dec 31, 2022
bootstrap: Get rid of tail_args in stream_cargo Based on rust-lang#106303 for convenience. r? ``@Mark-Simulacrum``
jyn514
added a commit
to jyn514/rust
that referenced
this pull request
Dec 31, 2022
bootstrap: Get rid of tail_args in stream_cargo Based on rust-lang#106303 for convenience. r? ```@Mark-Simulacrum```
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 31, 2022
…mpiler-errors Rollup of 9 pull requests Successful merges: - rust-lang#105903 (Unify id-based thread parking implementations) - rust-lang#106232 (CFI: Monomorphize transparent ADTs before typeid) - rust-lang#106248 (Revert "Implement allow-by-default `multiple_supertrait_upcastable` lint") - rust-lang#106286 (Make tidy errors red) - rust-lang#106295 (Extend scraped examples layout GUI test for position of buttons) - rust-lang#106305 ( bootstrap: Get rid of tail_args in stream_cargo) - rust-lang#106310 (Dont use `--merge-base` during bootstrap formatting subcommand) - rust-lang#106314 (Fix panic on `x build --help`) - rust-lang#106317 (Only deduplicate stack traces for good path bugs) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
JohnTitor
pushed a commit
to JohnTitor/rust
that referenced
this pull request
Jan 9, 2023
Revert "bootstrap: Get rid of `tail_args` in `stream_cargo`" This reverts commit 9dfe504. (Note: that merged as part of rust-lang#106305, but rust-lang#106305 contains more commits than just 9dfe504.) Fixes `x clippy`. It turns out `clippy` was the only one using `tail_args` 🤦 sorry for not testing this earlier. r? `@Mark-Simulacrum`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #106303 for convenience.
r? @Mark-Simulacrum