Unify id-based thread parking implementations

[joboet]

Multiple platforms currently use thread-id-based parking implementations (NetBSD and SGX¹). Even though the strategy does not differ, these are duplicated for each platform, as the id is encoded into an atomic thread variable in different ways for each platform.

Since park is only called by one thread, it is possible to move the thread id into a separate field. By ensuring that the field is only written to once, before any other threads access it, these accesses can be unsynchronized, removing any restrictions on the size and niches of the thread id.

This PR also renames the internal thread_parker modules to thread_parking, as that name now better reflects their contents. I hope this does not add too much reviewing noise.

r? @m-ou-se

@rustbot label +T-libs

Footnotes

1. SOLID supports this as well, I will switch it over in a follow-up PR. ↩

[rustbot]

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

• Stabilizing library features
• Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
• Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
• Changing public documentation in ways that create new stability guarantees
• Changing observable runtime behavior of library APIs

[bors]

☔ The latest upstream changes (presumably #100539) made this pull request unmergeable. Please resolve the merge conflicts.

[joboet]

@rustbot ready

[joboet]

@rustbot ready

[m-ou-se]

Thanks!

@bors r+

[bors]

📌 Commit 898302e has been approved by m-ou-se

It is now in the queue for this repository.

[bors]

⌛ Testing commit 898302e with merge 3183781d4ab598fabeca6e7bf03ccf4bd5d0e9d2...

[bors]

💔 Test failed - checks-actions

[ehuss]

@bors retry #106320

[rust-log-analyzer]

The job x86_64-gnu-stable failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

tidy: Skipping binary file check, read-only filesystem
Checking which error codes lack tests...
* 633 error codes
* highest error code: E0791
thread '<unnamed>' panicked at 'Encountered error while testing Git status: "failed to execute git log command: fatal: ambiguous argument ':!src/tools/miri': unknown revision or path not in the working tree.\nUse '--' to separate paths from revisions, like this:\n'git <command> [<revision>...] -- [<file>...]'\n"', src/tools/tidy/src/no_merge.rs:23:25
Found 507 error codes
Found 0 error(s) in error codes
Done!
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Any { .. }', src/tools/tidy/src/main.rs:42:61

[bors]

⌛ Testing commit 898302e with merge e119b8e065f0f3f34090daa1c27db2d2793cde8a...

[compiler-errors]

Yield to rollup

@bors retry

[bors]

⌛ Testing commit 898302e with merge 247e44e...

[rust-log-analyzer]

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)