Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: clearify that mip.{MSIP, MTIP} are read-only #108

Merged
merged 1 commit into from
Aug 14, 2022
Merged

fix: clearify that mip.{MSIP, MTIP} are read-only #108

merged 1 commit into from
Aug 14, 2022

Conversation

luojia65
Copy link
Contributor

@luojia65 luojia65 commented Aug 14, 2022 •
edited
Loading

closes #62

In RISC-V privileged specification, it says:

Bits mip.MTIP and mie.MTIE are the interrupt-pending and interrupt-enable bits for machine timer interrupts. MTIP is read-only in mip, and is cleared by writing to the memory-mapped machine-mode timer compare register.

Bits mip.MSIP and mie.MSIE are the interrupt-pending and interrupt-enable bits for machine-level software interrupts. MSIP is read-only in mip, and is written by accesses to memory-mapped control registers, which are used by remote harts to provide machine-level interprocessor interrupts.

indicated by the specification, mip.MSIP and mip.MTIP bits are read-only. This pull request clearifies this by removing {set, clear}_{msoft, mtimer} functions from mip module of riscv crate.

@luojia65 luojia65 requested a review from a team as a code owner August 14, 2022 02:20
almindor
almindor approved these changes Aug 14, 2022
View reviewed changes
Copy link
Contributor

@almindor almindor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice find. thanks!

@almindor
Copy link
Contributor

bors r+

@bors
Copy link
Contributor

bors bot commented Aug 14, 2022

Build succeeded:

@bors bors bot merged commit 98ae3aa into rust-embedded:master Aug 14, 2022
romancardenas pushed a commit that referenced this pull request Nov 17, 2023
@bors @tfx2001
Merge #108
3859409 
108: update to riscv 0.10 r=dkhayes117 a=tfx2001

In `svd2rust` 0.24.2, require `critial-section` feature of `riscv` 0.10.0 to use the `Peripheral::take()`. So update `riscv` to 0.10 avoid link error.

```text
  = note: rust-lld: error: undefined symbol: _critical_section_1_0_release
          >>> referenced by lib.rs:197 (C:\***\.cargo\registry\src\github.51.al-1ecc6299db9ec823\critical-section-1.1.1\src/lib.rs:197)
          >>>               C:\***\target\riscv32imac-unknown-none-elf\debug\deps\blink-38e172683ad1eb45.21kbt3gcucoa48u6.rcgu.o:(core::ptr::drop_in_place$LT$critical_section..with..Guard$GT$::h47fa1a207a83c94b)

          rust-lld: error: undefined symbol: _critical_section_1_0_acquire
          >>> referenced by lib.rs:180 (C:\***\.cargo\registry\src\github.51.al-1ecc6299db9ec823\critical-section-1.1.1\src/lib.rs:180)
          >>>               C:\***\target\riscv32imac-unknown-none-elf\debug\deps\blink-38e172683ad1eb45.54bke7unpav17a81.rcgu.o:(critical_section::with::h3ba86eebd468f130)
```

Co-authored-by: tfx2001 <tfx2001@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@almindor almindor almindor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The MTIP bit in mip register is read-only
2 participants
@luojia65 @almindor