Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MotorTemperaturePublisher tool #951

Merged
merged 3 commits into from
Mar 15, 2024

Conversation

MSECode
Copy link
Contributor

@MSECode MSECode commented Mar 11, 2024

Add to src/tools a new tool called motorTemperaturePublisher which might be helpful for publishing the motor temperatures read from the ETH callback on the software. As things now the module can be started and used on a single robot subpart at the same time. So, if you need to check the temperature of multiple subparts or you start multiple instances of the application or you change the app/conf/config.ini file each time defining under portprefix the subpart that you need and in listofjoints the list of the jonts you desire to read the temperature.

All other specific info about what the module does and how to build it can be found in the README.md

@MSECode MSECode self-assigned this Mar 11, 2024
@MSECode MSECode requested a review from valegagge March 11, 2024 14:24
@MSECode MSECode marked this pull request as draft March 11, 2024 14:24
@pattacini pattacini linked an issue Mar 11, 2024 that may be closed by this pull request
Copy link
Member

@pattacini pattacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some points to address:

src/tools/motorTemperaturePublisher/CMakeLists.txt Outdated Show resolved Hide resolved
src/tools/motorTemperaturePublisher/CMakeLists.txt Outdated Show resolved Hide resolved
src/tools/motorTemperaturePublisher/CMakeLists.txt Outdated Show resolved Hide resolved
src/tools/motorTemperaturePublisher/README.md Outdated Show resolved Hide resolved
@MSECode MSECode force-pushed the feature/motorTemperaturePublisher branch from b5d4c87 to 623fcba Compare March 11, 2024 17:14
Copy link

sonarcloud bot commented Mar 11, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
9.1% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Copy link
Member

@pattacini pattacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some further comments to address, plus these general indications:

@MSECode MSECode force-pushed the feature/motorTemperaturePublisher branch from 623fcba to d3d2aac Compare March 14, 2024 14:13
@MSECode MSECode force-pushed the feature/motorTemperaturePublisher branch from d3d2aac to 48e7718 Compare March 14, 2024 14:17
Co-authored-by: Ugo Pattacini <ugo.pattacini@iit.it>
@MSECode MSECode marked this pull request as ready for review March 14, 2024 16:18
@MSECode MSECode marked this pull request as draft March 14, 2024 16:19
@MSECode MSECode marked this pull request as ready for review March 14, 2024 16:28
Copy link
Member

@pattacini pattacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The very last point is to extend this CMakeLists.txt file:

@MSECode MSECode force-pushed the feature/motorTemperaturePublisher branch from 00e512c to 8e2424d Compare March 14, 2024 17:37
@MSECode MSECode force-pushed the feature/motorTemperaturePublisher branch from 8e2424d to 60e8b64 Compare March 14, 2024 17:56
@pattacini pattacini merged commit 4286824 into robotology:devel Mar 15, 2024
4 checks passed
@MSECode MSECode deleted the feature/motorTemperaturePublisher branch June 13, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a tool to read the motor temperature
2 participants