Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a tool to read the motor temperature #940

Closed
valegagge opened this issue Feb 15, 2024 · 6 comments · Fixed by #951
Closed

Add a tool to read the motor temperature #940

valegagge opened this issue Feb 15, 2024 · 6 comments · Fixed by #951
Assignees

Comments

@valegagge
Copy link
Member

Is your feature request related to a problem?

Currently, the motor temperature is not published on the stateExt port.

The solution you would like to have available

We need an application that reads the temperatures of a part or a subset of a part and publishes it on a port to plot with yarpscope

Alternatives you have considered

No response

Additional context

No response

@valegagge
Copy link
Member Author

Just some tips:

  • the motionControlModule can be added in src/tools
  • its configuration files can be inserted in app folder and collected in a new folder with the name of the module. Please follow the camel case convention.

@pattacini
Copy link
Member

pattacini commented Feb 15, 2024

I would only find a better self-explaining name 😄

Just a couple of examples to give you an idea:

  • motorTemperatureDumper
  • motorTemperaturePublisher

@pattacini
Copy link
Member

pattacini commented Feb 15, 2024

Hi @valegagge

Going on with the addition of this new module is perfectly fine with me, as agreed T2T 👍🏻

I forgot to mention that there also exists a general-purpose control board dumper1 specifically designed to acquire a bunch of data that is not usually published on YARP, which in theory could be extended at will with new information. It's a quite old piece of SW2 but still in place.

Mentioned this only for the sake of completeness from a system perspective.

Footnotes

  1. 🌐 Documentation.

  2. Actually, part of that data is now regularly published via stateExt, I believe.

@valegagge
Copy link
Member Author

Hi @pattacini,
thank you for all the tips!

I know the control board dumper. It publishes the temperatures also, but it calls the getTepersature**s** API that in case of an error in one of a sensor it returns false for all the sensors.

So I prefer to use the API for single joint. Anyway, we can consider changing it with the call to the API for single joint, but, if I'm not mistaken, it is hard to change for its general-purpose design. I still need to check the code...

Concerning the name, for sure we need to use one more significant... 😸

@pattacini pattacini linked a pull request Mar 11, 2024 that will close this issue
@pattacini
Copy link
Member

Development integrated in devel via:

Closing.
Feel free to open it up again if required.

@pattacini
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants