Prevent scripts/run_all.py from bit-rotting
#4710
Comments
|
cc @jprochazk |
### What * Bumps arrow to 14.0.2 * Fixes #3699 * Relates to #2445 I added a bunch of fixes to `scripts/run_all.py`, which has a marked tendency to bit rot: * #4710 Some workaround introduced to deal with PyTorch not 3.12 ready, see: - #4704 TODO: - [x] `nox -s tests-3.12` passing - [x] `nox -s run_all-3.12 --save` passing - [x] `nox -s roundtrips-3.12` passing - [x] Solve this: ``` ❯ pixi add pyarrow==14.0.0 × could not determine any available versions for pyarrow on linux-64. Either the package could not be found or version constraints on other dependencies result in a conflict. ╰─▶ Cannot solve the request because of: No candidates were found for pyarrow ==14.0.0. ``` - [x] Test won't pass until torch is updated for 3.12: pytorch/pytorch#110436 ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/4146) (if applicable) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG - [PR Build Summary](https://build.rerun.io/pr/4146) - [Docs preview](https://rerun.io/preview/c0e892a228fcc83e9bef7faff1e17998926ffe52/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/c0e892a228fcc83e9bef7faff1e17998926ffe52/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://ref.rerun.io/dev/bench/) - [Wasm size tracking](https://ref.rerun.io/dev/sizes/)
We'd have to run it on CI for maximum confidence, but we don't want to and/or can't right now. At least not with all the different possible combinations. Are there any other things we could do? |
Minimally, if we had some checklist of manual tests to run before a release that would include running the various |
|
This script has significant overlap with I suggest we remove |
|
I took a quick look at this, and I'm no longer entirely sure it's worth re-implementing in rust. However, there are other ways to avoid bitrot, including running on the CI (at least night or maybe on push to main). That can be made easier with: |
In #4146, I had to make a bunch of fixes to
run_all.pyto have a successful run. We should somehow try to avoid this script from bit-rotting.The text was updated successfully, but these errors were encountered: