Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Python 3.12 #3699

Closed
abey79 opened this issue Oct 5, 2023 · 4 comments · Fixed by #4146
Closed

Support Python 3.12 #3699

abey79 opened this issue Oct 5, 2023 · 4 comments · Fixed by #4146
Assignees
@abey79
Labels
blocked can't make progress right now 🐍 Python API Python logging API
Milestone
Triage

Comments

@abey79
Copy link
Member

abey79 commented Oct 5, 2023

Python 3.12.0 was recently released (Oct, 2nd) and we should support it.

This is currently blocked by pyarrow 3.12 wheel availability:
@abey79 abey79 added the 🐍 Python API Python logging API label Oct 5, 2023
@emilk emilk added the blocked can't make progress right now label Oct 9, 2023
@emilk emilk added this to the 0.9.1 milestone Oct 9, 2023
@nikolausWest nikolausWest modified the milestones: 0.9.1, 0.10 Polish Oct 9, 2023
@emilk emilk removed the blocked can't make progress right now label Oct 24, 2023
@emilk
Copy link
Member

emilk commented Oct 24, 2023

Still waiting for pyarrow 14 to show up on pypi

@emilk emilk added the blocked can't make progress right now label Oct 24, 2023
@abey79 abey79 mentioned this issue Oct 30, 2023
Closed
@abey79
Copy link
Member Author

abey79 commented Nov 5, 2023

PyArrow 14 is up 🎉

But still soft-blocked on pytorch/pytorch#110436 (we use it in our test suite).

@abey79 abey79 mentioned this issue Nov 6, 2023
Merged
9 tasks
@jleibs
Copy link
Member

jleibs commented Nov 6, 2023

Our conda build will need to wait for:

@h-vetinari
Copy link

FYI, in conda-forge, we support python 3.12 on pyarrow 13.x since more than a month already.

jleibs pushed a commit that referenced this issue Jan 5, 2024
@abey79
Add support for Python 3.12 (#4146)
67d6dd8 
### What

* Bumps arrow to 14.0.2
* Fixes #3699
* Relates to #2445

I added a bunch of fixes to `scripts/run_all.py`, which has a marked
tendency to bit rot:
* #4710

Some workaround introduced to deal with PyTorch not 3.12 ready, see:
- #4704

TODO:
- [x] `nox -s tests-3.12` passing
- [x] `nox -s run_all-3.12 --save` passing
- [x] `nox -s roundtrips-3.12` passing
- [x] Solve this:
  ```
  ❯ pixi add pyarrow==14.0.0 
× could not determine any available versions for pyarrow on linux-64.
Either the package could not be found or version constraints on other
dependencies result in a conflict.
╰─▶ Cannot solve the request because of: No candidates were found for
pyarrow ==14.0.0.
  ```
- [x] Test won't pass until torch is updated for 3.12:
pytorch/pytorch#110436

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/4146) (if
applicable)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/4146)
- [Docs
preview](https://rerun.io/preview/c0e892a228fcc83e9bef7faff1e17998926ffe52/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/c0e892a228fcc83e9bef7faff1e17998926ffe52/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://ref.rerun.io/dev/bench/)
- [Wasm size tracking](https://ref.rerun.io/dev/sizes/)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abey79 abey79

Labels
blocked can't make progress right now 🐍 Python API Python logging API
Projects
None yet
Milestone
Triage
Development

Successfully merging a pull request may close this issue.

Add support for Python 3.12 rerun-io/rerun
5 participants
@emilk @nikolausWest @jleibs @h-vetinari @abey79