Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rtm 7 18 fix ci #153

Merged
merged 12 commits into from
Aug 7, 2023
Merged

Rtm 7 18 fix ci #153

merged 12 commits into from
Aug 7, 2023

Conversation

ryantm
Copy link
Collaborator

@ryantm ryantm commented Jul 18, 2023 •
edited by airportyh
Loading

Why

CI is broken

What changed

  • fixes from Breno
  • fixes all flake8 warnings
  • fixed the unittests:
    • updated jwt repl used to https://replit.com/@util/database-test-jwt
    • remove --no-root option from poetry run command, which prevented replit modules from being recognized
    • skipped TestIndentity.test_verify_ghostwriter for now
  • Added docs for how to run the tests

Test plan

  • CI passes

Rollout

Describe any procedures or requirements needed to roll this out safely (or check the box below)

  • This is fully backward and forward compatible

@ryantm ryantm requested a review from a team as a code owner July 18, 2023 15:31
@ryantm ryantm requested review from masad-frost and removed request for a team July 18, 2023 15:31
@ryantm ryantm marked this pull request as draft July 18, 2023 15:31
Replit user and others added 5 commits July 18, 2023 08:33
@ryantm
Update package versions
7560b39
@ryantm
update semaphore jobs
9fa4388
@ryantm
ignore Any -> Any flake8 warning
2f933e3
@ryantm
ignore requests lint
ce1fe7c 
It thought this was a call to the requests library, but it is justs a
dictionary named num_requests.
@ryantm
run black formating
670ee61 
* flake8 was complaining that black would format some files
@airportyh airportyh marked this pull request as ready for review August 7, 2023 14:45
@airportyh airportyh self-requested a review August 7, 2023 14:48
@ryantm ryantm merged commit c650eb2 into master Aug 7, 2023
@ryantm ryantm deleted the rtm-7-18-fix-ci branch August 7, 2023 14:59
@junyu junyu mentioned this pull request Aug 15, 2023
Merged
@blast-hardcheese blast-hardcheese added the chore Incidental change that should not impact released library label Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@airportyh airportyh airportyh approved these changes

@masad-frost masad-frost Awaiting requested review from masad-frost masad-frost is a code owner automatically assigned from replit/devex

Assignees
No one assigned
Labels
chore Incidental change that should not impact released library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ryantm @airportyh @blast-hardcheese