Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump typing_extensions #150

Merged
merged 1 commit into from
Jul 17, 2023
Merged

bump typing_extensions #150

merged 1 commit into from
Jul 17, 2023

Conversation

ryantm
Copy link
Collaborator

@ryantm ryantm commented Jul 17, 2023

Why

  • We have reports of incompatibility with new packages that use typing_extensions v4

What changed

  • Updated typing_extensions bound to ^4
  • Updated lock file

Test plan

  • Ran Breno's test web app with these changes

@ryantm ryantm requested review from a team and airportyh and removed request for a team July 17, 2023 17:50
airportyh
airportyh approved these changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@airportyh airportyh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ryantm ryantm force-pushed the rtm-7-17-typing_extensions-bump branch from 32039fc to cb62ea2 Compare July 17, 2023 19:05
@ryantm ryantm requested a review from a team as a code owner July 17, 2023 19:05
@ryantm ryantm requested review from masad-frost and removed request for a team July 17, 2023 19:05
@ryantm ryantm merged commit 3e558a4 into master Jul 17, 2023
@ryantm ryantm deleted the rtm-7-17-typing_extensions-bump branch July 17, 2023 19:08
@noneofyourbusiness1415252 noneofyourbusiness1415252 mentioned this pull request Aug 9, 2023
Closed
@junyu
Copy link

junyu commented Aug 15, 2023

Unfortunately this has been overwritten by #153

@blast-hardcheese blast-hardcheese added the chore Incidental change that should not impact released library label Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@airportyh airportyh airportyh approved these changes

@masad-frost masad-frost Awaiting requested review from masad-frost masad-frost is a code owner automatically assigned from replit/devex

Assignees
No one assigned
Labels
chore Incidental change that should not impact released library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ryantm @junyu @airportyh @blast-hardcheese