-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(modify): Allow picking fields #79
Merged
sandrina-p
merged 8 commits into
main
from
pbyr-1371-jsf-modify-module-allow-picking-fields
Jul 25, 2024
Merged
feat(modify): Allow picking fields #79
sandrina-p
merged 8 commits into
main
from
pbyr-1371-jsf-modify-module-allow-picking-fields
Jul 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey @sandrina-p , I'll review this one tomorrow morning! |
@danielcardoso5 Ready for a new review :D |
sandrina-p
force-pushed
the
pbyr-1371-jsf-modify-module-allow-picking-fields
branch
from
July 17, 2024 10:00
4b9fd46
to
3535f78
Compare
danielcardoso5
previously approved these changes
Jul 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @sandrina-p! Thank you for the added comments re: fieldsets ✨
sandrina-p
force-pushed
the
pbyr-1371-jsf-modify-module-allow-picking-fields
branch
2 times, most recently
from
July 24, 2024 15:59
f24214d
to
5c7b88d
Compare
sandrina-p
commented
Jul 24, 2024
danielcardoso5
previously approved these changes
Jul 25, 2024
sandrina-p
force-pushed
the
pbyr-1371-jsf-modify-module-allow-picking-fields
branch
from
July 25, 2024 15:36
b0d04b7
to
c8cc064
Compare
danielcardoso5
previously approved these changes
Jul 25, 2024
sandrina-p
force-pushed
the
pbyr-1371-jsf-modify-module-allow-picking-fields
branch
from
July 25, 2024 16:02
c8cc064
to
a1ddaff
Compare
danielcardoso5
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #71, scoped on allowing to pick certain fields
Linear issue (internal)
New specs
Imagine the schema below with 4 fields to buy tickets:
If you want a JSON Schema with just the
quantity
field, pass the following config:Which will return you the schema:
Other features:
warnings
.