-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(modify): Allow creating fields #80
Merged
sandrina-p
merged 11 commits into
main
from
expm-631-jsf-modify-module-allow-adding-new-fields
Jul 24, 2024
Merged
feat(modify): Allow creating fields #80
sandrina-p
merged 11 commits into
main
from
expm-631-jsf-modify-module-allow-adding-new-fields
Jul 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandrina-p
force-pushed
the
expm-631-jsf-modify-module-allow-adding-new-fields
branch
from
July 18, 2024 21:46
052fbef
to
defb1de
Compare
sandrina-p
commented
Jul 18, 2024
sandrina-p
changed the title
feat(modify): Allow adding new fields
feat(modify): Allow creating fields
Jul 18, 2024
This was referenced Jul 19, 2024
sandrina-p
force-pushed
the
expm-631-jsf-modify-module-allow-adding-new-fields
branch
from
July 24, 2024 13:56
97d99e6
to
cddf09d
Compare
sandrina-p
commented
Jul 24, 2024
danielcardoso5
previously approved these changes
Jul 24, 2024
danielcardoso5
previously approved these changes
Jul 24, 2024
…te does not edit fields
sandrina-p
force-pushed
the
expm-631-jsf-modify-module-allow-adding-new-fields
branch
from
July 24, 2024 15:36
84e3930
to
a33dd02
Compare
eng-almeida
approved these changes
Jul 24, 2024
sandrina-p
deleted the
expm-631-jsf-modify-module-allow-adding-new-fields
branch
July 24, 2024 15:56
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #71, scoped on allowing to add new fields
Linear issue (internal)
New specs
Imagine the schema with 2 fields:
If you want to add a new field to the JSON Schema pass the following config:
Which will return the schema:
Creating an existing field
If you try to create a field that already exists, it get's ignored and it returns a
warning
.Here's an example with the
age
field based on thebaseSchema
above.Check tests for more examples.
Other features: