[JSON Logic] Part 2: Computed Attribute skeleton #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brennj
force-pushed
the
json-logic-add-computedattrs
branch
from
74adaf4
to
f990a57
Compare
This was referenced Aug 23, 2023
johnstonbl01
previously requested changes
Aug 25, 2023
dilvane
reviewed
Aug 28, 2023
dilvane
reviewed
Aug 28, 2023
sandrina-p
reviewed
Aug 29, 2023
brennj
force-pushed
the
json-logic-skeleton
branch
from
da5c220
to
7adee33
Compare
brennj
force-pushed
the
json-logic-add-computedattrs
branch
from
f990a57
to
6b06f89
Compare
chore: clean up conditional additions chore: remove const tests chore: remove dupe file chore: remove group array stuff chore: clean up yupschema chore: clean up helpers a small bit chore: remove all error handling for now chore: clean up package-lock chore: more removing stuff chore: clean more
brennj
force-pushed
the
json-logic-add-computedattrs
branch
from
6b06f89
to
d2cc213
Compare
sandrina-p
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires: #34 and #35 for full context and to work correctly. Must only be merged when they are.
This is a breakdown of #28 to make it more digestible for review.
Add in x-jsf-logic-computedAttrs (with reference to values defined in x-jsf-logic.computedValues) support.
x-jsf-logicComputedAttrsare present, it reads fromx-jsf-logic.computedValuesfor that computed value.