[JSON-Logic] Part 0: Allow consts to support single values only #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brennj
changed the title
This was referenced Aug 22, 2023
johnstonbl01
previously approved these changes
Aug 24, 2023
This reverts commit ff0d02b.
sandrina-p
reviewed
Aug 29, 2023
sandrina-p
reviewed
Aug 29, 2023
|
@sandrina-p are you the admin on this repo? Can we change it so that new commits dismiss old reviews? if you or @johnstonbl01 can give this a "reapproval" i think we can merge now, green internally now! |
sandrina-p
reviewed
Aug 30, 2023
sandrina-p
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 1 of merging JSON Logic schemas in, but this is really its own standalone piece of work.
Today if we have a
constvalue in a schema, it doesn't take into account validations to only allow that value.With this PR, it adds that functionality to cause an error, also where you can define the custom error using
x-jsf-errorMessage.const.Please see the tests for sample schemas on how to make this work.