docs: Add docs (build) #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Merged
sandrina-p
force-pushed
the
copy-docs-build
branch
from
5170cc4
to
1dc8677
Compare
johnstonbl01
approved these changes
May 16, 2023
Cool! Which "updates at the bottom" are you talking about? |
|
sandrina-p
added a commit
that referenced
this pull request
May 17, 2023
This commit was amended in the "main" branch to add the co-authors, which caused the lost of the Merge commit from #2 Co-authored-by: António Capelo <antoniocapelo@users.noreply.github.com> Co-authored-by: João Almeida <eng-almeida@users.noreply.github.com> Co-authored-by: Hanli Theron <HanliTheron@users.noreply.github.com> Co-authored-by: John Brennan <brennj@users.noreply.github.com> Co-authored-by: Dilvane Zanardine <dilvane@users.noreply.github.com> Co-authored-by: Blake Johnston <johnstonbl01@users.noreply.github.com> Co-authored-by: Zofia Korcz <Calanthe@users.noreply.github.com>
sandrina-p
added a commit
that referenced
this pull request
Nov 7, 2023
) * fix: Remove stale attributes from conditionals * Do not remove "type" while it is being deprecated * realistic examples * remove console.log * Spot a bug, added a test to cover it. fix needed * fix latest bug found. all good * self-review * self-review #2 * Release 0.7.2-dev.20231106093837 * delete unsused rootFieldAttrs param * delete unneded default examples * jsdcos remove x an y * Revert back to 0.7.2-beta.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This library was part of
@remotecominternal source code.As we are open-sourcing it, this is the docs (build version).
The library code itself is copied at #1 .
Why not open-sourcing the docs' source?
Although the library code is open-sourced with unit tests, the docs cannot be moved yet. Our docs are still coupled to Remote's internal Design System and integration tests. The effort to decouple it at the moment is too high.
So our strategy is to at each new PR, to update the docs internally and manually copy its build to this repo.
How to review this