Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Initial release #1

Merged
merged 2 commits into from
May 17, 2023
Merged

feat: Initial release #1

merged 2 commits into from
May 17, 2023

Conversation

sandrina-p
Copy link
Collaborator

@sandrina-p sandrina-p commented May 16, 2023

This library was part of @remotecom internal source code.

As we are open-sourcing it, this is a copy-paste of its sourcecode.

The docs are copied at #2.

How to review this:

  • Check if the README looks good
  • Check if the package.json looks good
  • ESLint/Prettier and Husky are working correctly
  • The tests are passing (Already connected to the CI using Github actions)
  • Changes to src/ are out of scope as they are copy-paste

@vercel
Copy link

vercel bot commented May 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
json-schema-form ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2023 0:36am

@sandrina-p sandrina-p requested a review from brennj May 16, 2023 15:14
@sandrina-p sandrina-p mentioned this pull request May 16, 2023
---

### Why JSON Schemas for forms?
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't find the link, is the JSON schema article published? Might be fun to include it?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I swear I answer this comment yesterday, but it's gone. The article was not published yet. But once it is, I'll add it here!

package.json Show resolved Hide resolved
package.json Show resolved Hide resolved
@brennj
Copy link
Collaborator

brennj commented May 16, 2023

My comments aren't blockers, i think this is great. Maybe i'm not seeing the same as @johnstonbl01 - it seems all the check stuff seems good from what i can see?

Copy link
Collaborator

@brennj brennj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not me getting very confused wondering where approve button was. But yes, nothing blocker for me

sandrina-p and others added 2 commits May 17, 2023 13:35
Co-authored-by: António Capelo <antoniocapelo@users.noreply.github.com>
Co-authored-by: João Almeida <eng-almeida@users.noreply.github.com>
Co-authored-by: Hanli Theron <HanliTheron@users.noreply.github.com>
Co-authored-by: John Brennan <brennj@users.noreply.github.com>
Co-authored-by: Dilvane Zanardine <dilvane@users.noreply.github.com>
Co-authored-by: Blake Johnston <johnstonbl01@users.noreply.github.com>
Co-authored-by: Zofia Korcz <Calanthe@users.noreply.github.com>
@sandrina-p sandrina-p merged commit 9a68735 into main May 17, 2023
@sandrina-p sandrina-p deleted the copy-sourcecode branch May 17, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants