Do not wait for the reallocation batch to finish #9992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michal Maslanka <michal@redpanda.com>
Signed-off-by: Michal Maslanka <michal@redpanda.com>
mmaslankaprv
force-pushed
the
queue-based-balancing
branch
2 times, most recently
from
b3cf6d8
to
c9b8238
Compare
ztlpn
reviewed
Apr 13, 2023
Replaced a vector of reallcations with a map where `ntp` is a key. This will allow for fast lookups when checking if partition was already scheduled for realloaction. Signed-off-by: Michal Maslanka <michal@redpanda.com>
Renamed `reallocate_replica_set` method to `reconcile_reallocation_state` to express the complexity of state changes that the method is responsible for. Signed-off-by: Michal Maslanka <michal@redpanda.com>
Changed the logic in `cluster::members_backend` to calculate reallocations when pending reallocation count is smaller than max reallocation batch size. This way the available learner recovery bandwith may be fully utilized and node operations may finish faster. Signed-off-by: Michal Maslanka <michal@redpanda.com>
mmaslankaprv
force-pushed
the
queue-based-balancing
branch
from
c9b8238
to
939bf11
Compare
ztlpn
approved these changes
Apr 14, 2023
|
Let's not forget to backport, @mmaslankaprv |
|
/backport v23.1.x |
|
Failed to run cherry-pick command. I executed the below command: |
7 tasks
mmaslankaprv
added a commit
that referenced
this pull request
Apr 17, 2023
[v23.1.x] Backport of #9992
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the logic in
cluster::members_backendto calculatereallocations when pending reallocation count is smaller than max
reallocation batch size. This way the available learner recovery
bandwidth may be fully utilised and node operations may finish faster.
Backports Required
Release Notes
Improvements