[v22.3.x] Backport of #9622 #9992 #9789 #10381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmaslankaprv
changed the title
mmaslankaprv
force-pushed
the
v22.3.x_rebalancing
branch
2 times, most recently
from
487a9d5
to
bab3b4a
Compare
Signed-off-by: Michal Maslanka <michal@redpanda.com> (cherry picked from commit fd7caa8)
Signed-off-by: Michal Maslanka <michal@redpanda.com> (cherry picked from commit a308539)
Introduced a reallation strategy type to make reallocation code testable and customizable outside of the members backend. Signed-off-by: Michal Maslanka <michal@redpanda.com> (cherry picked from commit d5716ab)
Using reservoir sampling to chose the replicas that are going to be reallocated to the new node provides better uniformity of topic replicas distribution across the cluster. Additionally reservoir sampling algorithm isn't prone to not selecting enough reallocations. Signed-off-by: Michal Maslanka <michal@redpanda.com> (cherry picked from commit d2456cc)
Signed-off-by: Michal Maslanka <michal@redpanda.com> (cherry picked from commit fed7e9e)
Signed-off-by: Michal Maslanka <michal@redpanda.com> (cherry picked from commit 3f3e374)
Signed-off-by: Michal Maslanka <michal@redpanda.com> (cherry picked from commit 9436afc)
Signed-off-by: Michal Maslanka <michal@redpanda.com> (cherry picked from commit 09c5528)
Replaced a vector of reallcations with a map where `ntp` is a key. This will allow for fast lookups when checking if partition was already scheduled for realloaction. Signed-off-by: Michal Maslanka <michal@redpanda.com> (cherry picked from commit efa7edb)
Renamed `reallocate_replica_set` method to `reconcile_reallocation_state` to express the complexity of state changes that the method is responsible for. Signed-off-by: Michal Maslanka <michal@redpanda.com> (cherry picked from commit c70a861)
Changed the logic in `cluster::members_backend` to calculate reallocations when pending reallocation count is smaller than max reallocation batch size. This way the available learner recovery bandwith may be fully utilized and node operations may finish faster. Signed-off-by: Michal Maslanka <michal@redpanda.com> (cherry picked from commit 939bf11)
mmaslankaprv
force-pushed
the
v22.3.x_rebalancing
branch
from
bab3b4a
to
4d1f7a0
Compare
|
It does look like this PR added:
and is missing:
|
mmaslankaprv
changed the title
dotnwat
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backporting #9622 & #9992 & #9789
Dropped 7059fd1 introducing test due to conflicts.
Backports Required
Release Notes